[PPAPI] API thunk for video media stream track.

ppapi/thunk/ppb_media_stream_video_track_api.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_THUNK_MEDIA_STREAM_VIDEO_TRACK_API_H_
+#define PPAPI_THUNK_MEDIA_STREAM_VIDEO_TRACK_API_H_
+
+#include "ppapi/thunk/ppb_media_stream_track_api.h"
+
+namespace ppapi {
+namespace thunk {
+
+class PPB_MediaStreamVideoTrack_API : virtual public PPB_MediaStreamTrack_API{

[yzshen1, 2014/01/08 17:56:11]

- You don't need virtual inheritance here, right?
- one space before '{'.

[yzshen1, 2014/01/08 17:56:11]

Does it need PPAPI_THUNK_EXPORT?

[Peng, 2014/01/08 18:51:26]

Done.

[Peng, 2014/01/08 18:51:26]

I would like to implement some methods of PPB_MediaStreamTrack_API in the
MediaStreamTrackResourceBase.
And the MediaStreamVideoTrackResource will inherit from both
MediaStreamTrackResourceBase & PPB_MediaStreamVideoTrack_API. In that case, i
think virtual inheritance is needed here, right?

[yzshen1, 2014/01/08 19:01:45]

As I comment in the other CL. I think the MediaStreamTrackResourceBase should be
named MediaFrameBuffer and it should a member of other classes instead of a base
class.

This simplifies inheritance hierarchy. And it also gives us more flexibility,
for example, when frame size changes, the Track can simply create a new
MediaFrameBuffer member. 

.*_APIs should be pure interfaces. And I believe virtual inheritance is not
recommended. :)

On 2014/01/08 18:51:26, Peng wrote:

[Peng, 2014/01/08 21:48:37]

As we discussed offline. Only the MediaStreamBaseShared will be renamed to
MediaStreamFrameBuffer and used as a member field. And it is OK to keep
MediaStreamTrackResourceBase & 
MediaStreamTrackHostBase.

Done


On 2014/01/08 19:01:45, yzshen1 wrote:

+ public:
+  virtual ~PPB_MediaStreamVideoTrack_API() {}
+  virtual int32_t Configure(uint32_t max_buffered_frames) = 0;
+};
+
+}  // namespace thunk
+}  // namespace ppapi
+
+#endif  // PPAPI_THUNK_MEDIA_STREAM_VIDEO_TRACK_API_H_