Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 126823006: SyncControlVSyncProvider: throttle messages when MSC=0 (Closed)

Created:
6 years, 11 months ago by Daniel Kurtz
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

SyncControlVSyncProvider: throttle messages when MSC=0 Most X DRI2 drivers return TRUE for GetSyncValues with a MSC value of 0 if they cannot deduce on which CRTC the Drawable is being displayed, or that CRTC is currently disabled. This can happen if the associated CRTC is powered off, or if its framebuffer is being rotated, etc. Once the driver is in this situation, all MSC == 0 values will be returned until the CRTC can be found again. Currently, we spam the log every time we receive msc==0, which fills up the disk, makes the GPU log unusable, and causes lots of confusion when devs are trying to debug other issues. Instead, let's just log exactly once every time this situation is detected. Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>; BUG=231945 TEST=Manual on chromeos: # Enable some slowly updating page on each monitor, for example: http://www.24webclock.com/ tail -F /var/log/chrome/chrome | grep glXGetSyncValuesOML & set_short_timeouts # Let the displays turn off (~35 seconds) => This message should be printed exactly once per attached display: glXGetSyncValuesOML should not return TRUE with a media stream counter of 0. # Turn displays back on (tap a key), and let them idle off again. => The same message should be printed exactly once per attached display. R=marcheu@chromium.org R=piman@chromium.org R=backer@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243548

Patch Set 1 #

Patch Set 2 : Added piman as OWNER #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M ui/gl/sync_control_vsync_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
LGTM. FYI, git cl associates a CL with a git branch, so if you created ...
6 years, 11 months ago (2014-01-08 05:09:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djkurtz@chromium.org/126823006/30001
6 years, 11 months ago (2014-01-08 05:20:35 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 13:07:29 UTC) #3
Message was sent while issue was closed.
Change committed as 243548

Powered by Google App Engine
This is Rietveld 408576698