Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 1268153002: Refactor CreateOpenerProxies to support updates to frame openers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Charlie's nits Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 10
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 void CreateProxiesForNewRenderFrameHost(SiteInstance* old_instance, 611 void CreateProxiesForNewRenderFrameHost(SiteInstance* old_instance,
612 SiteInstance* new_instance, 612 SiteInstance* new_instance,
613 int* create_render_frame_flags); 613 int* create_render_frame_flags);
614 614
615 // Create swapped out RenderViews and RenderFrameProxies in the given 615 // Create swapped out RenderViews and RenderFrameProxies in the given
616 // SiteInstance for all frames on the opener chain of this frame. Same as 616 // SiteInstance for all frames on the opener chain of this frame. Same as
617 // CreateOpenerProxies, but starts from this frame's opener, calling 617 // CreateOpenerProxies, but starts from this frame's opener, calling
618 // CreateOpenerProxies on it if it exists and returning otherwise. 618 // CreateOpenerProxies on it if it exists and returning otherwise.
619 void CreateOpenerProxiesIfNeeded(SiteInstance* instance); 619 void CreateOpenerProxiesIfNeeded(SiteInstance* instance);
620 620
621 // Traverse the opener chain and populate |opener_frame_trees| with
622 // all FrameTrees accessible by following frame openers of nodes in the
623 // given node's FrameTree. |opener_frame_trees| is ordered so that openers
624 // of smaller-indexed entries point to larger-indexed entries (i.e., this
625 // node's FrameTree is at index 0, its opener's FrameTree is at index 1,
626 // etc). If the traversal encounters a node with an opener pointing to a
627 // FrameTree that has already been traversed (such as when there's a cycle),
628 // the node is added to |nodes_with_back_links|.
629 void CollectOpenerFrameTrees(
630 std::vector<FrameTree*>* opener_frame_trees,
631 base::hash_set<FrameTreeNode*>* nodes_with_back_links);
632
633 // Create swapped out RenderViews and RenderFrameProxies in the given
634 // SiteInstance for the current node's FrameTree. Used as a helper function
635 // in CreateOpenerProxies for creating proxies in each FrameTree on the
636 // opener chain.
637 void CreateOpenerProxiesForFrameTree(SiteInstance* instance);
638
621 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary. 639 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary.
622 scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(SiteInstance* instance, 640 scoped_ptr<RenderFrameHostImpl> CreateRenderFrameHost(SiteInstance* instance,
623 int view_routing_id, 641 int view_routing_id,
624 int frame_routing_id, 642 int frame_routing_id,
625 int flags); 643 int flags);
626 644
627 // PlzNavigate 645 // PlzNavigate
628 // Creates and initializes a speculative RenderFrameHost and/or WebUI for an 646 // Creates and initializes a speculative RenderFrameHost and/or WebUI for an
629 // ongoing navigation. They might be destroyed and re-created later if the 647 // ongoing navigation. They might be destroyed and re-created later if the
630 // navigation is redirected to a different SiteInstance. 648 // navigation is redirected to a different SiteInstance.
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 bool should_reuse_web_ui_; 811 bool should_reuse_web_ui_;
794 812
795 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 813 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
796 814
797 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 815 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
798 }; 816 };
799 817
800 } // namespace content 818 } // namespace content
801 819
802 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 820 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698