Issue 12681013: Fix MMAP_LIST in dumps by deep-heap-profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12681013: Fix MMAP_LIST in dumps by deep-heap-profile. (Closed)

Created:
7 years, 9 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
7 years, 9 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix MMAP_LIST in dumps by deep-heap-profile. bucket_id in MMAP_LIST was wrong (only 0). This change fixes the issue by changing the scope and the oparation order. BUG=181517 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190835

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	third_party/tcmalloc/chromium/src/deep-heap-profile.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

Dai Mikurube (NOT FULLTIME)

Committed patchset #1 manually as r190835 (presubmit successful).

7 years, 9 months ago (2013-03-27 06:49:59 UTC) #1

Dai Mikurube (NOT FULLTIME)

Sorry for the TBR change, Alexander. We didn't notice this issue since this MMAP_LIST dump ...

7 years, 9 months ago (2013-03-27 06:52:19 UTC) #2

Dai Mikurube (NOT FULLTIME)

7 years, 9 months ago (2013-03-27 07:24:04 UTC) #4

Message was sent while issue was closed.

On 2013/03/27 07:11:24, Alexander Potapenko wrote:
> LGTM

Thanks!