Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 126803003: Port nameservice test from nacl_integration to browser_tests. (Closed)

Created:
6 years, 11 months ago by Nick Bray (chromium)
Modified:
6 years, 11 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Port nameservice test from nacl_integration to browser_tests. This change requires rolling the NaCl DEPS to get untrusted libraries to build correctly. BUG=154400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243635

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -396 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/nacl_test_data.gyp View 2 chunks +61 lines, -0 lines 0 comments Download
A + chrome/test/data/nacl/nameservice/pm_nameservice_test.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/nacl/nameservice/pm_nameservice_test.html View 1 chunk +18 lines, -10 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/native_client/chrome_main.scons View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/nacl_browser/nameservice/nacl.scons View 1 chunk +0 lines, -40 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/nameservice/pm_nameservice_test.cc View 1 chunk +0 lines, -266 lines 0 comments Download
D ppapi/native_client/tests/nacl_browser/nameservice/pm_nameservice_test.html View 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nick Bray (chromium)
Remember your chromium account. OWNERS, and all that.
6 years, 11 months ago (2014-01-07 23:59:26 UTC) #1
bradnelson
LGTM, except for the failing try jobs. :-) Looks to be failing because there's no ...
6 years, 11 months ago (2014-01-08 00:42:03 UTC) #2
Nick Bray (chromium)
On 2014/01/08 00:42:03, bradnelson wrote: > LGTM, except for the failing try jobs. :-) > ...
6 years, 11 months ago (2014-01-08 00:58:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/126803003/150001
6 years, 11 months ago (2014-01-08 17:17:08 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 20:22:49 UTC) #5
Message was sent while issue was closed.
Change committed as 243635

Powered by Google App Engine
This is Rietveld 408576698