Fix breakpad for arm on arm64

client/linux/minidump_writer/linux_ptrace_dumper.cc

Index: client/linux/minidump_writer/linux_ptrace_dumper.cc
diff --git a/client/linux/minidump_writer/linux_ptrace_dumper.cc b/client/linux/minidump_writer/linux_ptrace_dumper.cc
index 5ea0050de58cb0bf05b7922b331150f900d5571c..db7f9e3219a17088007e64dcdaef5de302244f4f 100644
--- a/client/linux/minidump_writer/linux_ptrace_dumper.cc
+++ b/client/linux/minidump_writer/linux_ptrace_dumper.cc
@@ -209,7 +209,15 @@ bool LinuxPtraceDumper::GetThreadInfoByIndex(size_t index, ThreadInfo* info) {
   void* fp_addr;

[Lei Zhang, 2015/08/04 00:11:33]

- I would just skip this entire block on Android + ARM EABI.
-- BTW, with these #defines, the address |fp_addr| points to is not read in
client/linux/dump_writer_common/thread_info.cc.

- If you can add a comment here to reference a bug, that'll save on future code
archaeology time.

[cjhopman, 2015/08/04 23:28:45]

Done.

   info->GetFloatingPointRegisters(&fp_addr, NULL);
   if (sys_ptrace(PTRACE_GETFPREGS, tid, NULL, fp_addr) == -1) {
+#if defined(__ANDROID__) && defined(__ARM_EABI__)
+    // When running an arm build on an arm64 device, attempting to get the
+    // floating point registers fails with EIO. Ignore that error.
+    if (errno != EIO) {
+      return false;
+    }
+#else
     return false;
+#endif
   }
 #endif