chrome/browser/resources/md_downloads/item.html - Issue 1268023002: MD downloads: implement real warning icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/item.html

Issue 1268023002: MD downloads: implement real warning icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dl-search-x

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_downloads/item.html

diff --git a/chrome/browser/resources/md_downloads/item.html b/chrome/browser/resources/md_downloads/item.html

index 7539d6d82bbeedef65bc2ed5ddfe36404cc9ce71..abbfd6d320b2c38bec3ebbc65d84b6c1329c4eb3 100644

--- a/chrome/browser/resources/md_downloads/item.html

+++ b/chrome/browser/resources/md_downloads/item.html

@@ -19,7 +19,8 @@

<paper-material id="content" on-dragstart="onDragStart_">

- <img id="icon" alt="">

+ <img id="icon" alt="" hidden="[[isDangerous_]]">

+ <div class="warning" hidden="[[!isDangerous_]]"></div>

groby-ooo-7-16 2015/08/04 00:56:06 Curious - why one image, one div?

Dan Beam 2015/08/04 01:11:20 using <img> without any possibility of setting its

</div>