Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: lib/src/runner/reporter/compact.dart

Issue 1268013004: Don't print clock updates between prints. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Fix changelog. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/compact_reporter_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/reporter/compact.dart
diff --git a/lib/src/runner/reporter/compact.dart b/lib/src/runner/reporter/compact.dart
index 9b8b9616a6a5516b791d6030c171c35f4c3ce36b..61fe9084741961182d8aba72b15a86cbf0df3a74 100644
--- a/lib/src/runner/reporter/compact.dart
+++ b/lib/src/runner/reporter/compact.dart
@@ -302,9 +302,14 @@ class CompactReporter implements Reporter {
if (_engine.passed.length == _lastProgressPassed &&
_engine.skipped.length == _lastProgressSkipped &&
_engine.failed.length == _lastProgressFailed &&
- elapsed == _lastProgressElapsed &&
message == _lastProgressMessage &&
- truncate == _lastProgressTruncated) {
+ // Don't re-print just because the message became re-truncated, because
+ // that doesn't add information.
+ (truncate || !_lastProgressTruncated) &&
+ // If we printed a newline, that means the last line *wasn't* a progress
+ // line. In that case, we don't want to print a new progress line just
+ // because the elapsed time changed.
+ (_printedNewline || elapsed == _lastProgressElapsed)) {
return false;
}
« no previous file with comments | « CHANGELOG.md ('k') | test/runner/compact_reporter_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698