Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: net/base/client_cert_store_impl_unittest.cc

Issue 12680003: net: split net/ssl out of net/base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/client_cert_store_impl_nss.cc ('k') | net/base/client_cert_store_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/client_cert_store_impl_unittest.cc
diff --git a/net/base/client_cert_store_impl_unittest.cc b/net/base/client_cert_store_impl_unittest.cc
deleted file mode 100644
index fb2de796a15df60436a4fe15c2cdb468f05223ba..0000000000000000000000000000000000000000
--- a/net/base/client_cert_store_impl_unittest.cc
+++ /dev/null
@@ -1,152 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/base/client_cert_store_impl.h"
-
-#include <string>
-#include <vector>
-
-#include "base/files/file_path.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
-#include "net/base/cert_test_util.h"
-#include "net/base/test_data_directory.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace net {
-
-namespace {
-
-// "CN=Client Auth Test Root 1" - DER encoded DN of the issuer of client_1.pem.
-const unsigned char kAuthority1DN[] = {
- 0x30, 0x22, 0x31, 0x20, 0x30, 0x1e, 0x06, 0x03, 0x55, 0x04, 0x03, 0x0c,
- 0x17, 0x43, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x20, 0x41, 0x75, 0x74, 0x68,
- 0x20, 0x54, 0x65, 0x73, 0x74, 0x20, 0x52, 0x6f, 0x6f, 0x74, 0x20, 0x31
-};
-
-// "CN=Client Auth Test Root 2" - DER encoded DN of the issuer of client_2.pem.
-unsigned char kAuthority2DN[] = {
- 0x30, 0x22, 0x31, 0x20, 0x30, 0x1e, 0x06, 0x03, 0x55, 0x04, 0x03, 0x0c,
- 0x17, 0x43, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x20, 0x41, 0x75, 0x74, 0x68,
- 0x20, 0x54, 0x65, 0x73, 0x74, 0x20, 0x52, 0x6f, 0x6f, 0x74, 0x20, 0x32
-};
-
-} // namespace
-
-TEST(ClientCertStoreImplTest, EmptyQuery) {
- std::vector<scoped_refptr<X509Certificate> > certs;
- scoped_refptr<SSLCertRequestInfo> request(new SSLCertRequestInfo());
-
- ClientCertStoreImpl store;
- std::vector<scoped_refptr<X509Certificate> > selected_certs;
- bool rv = store.SelectClientCerts(certs, *request, &selected_certs);
- EXPECT_TRUE(rv);
- EXPECT_EQ(0u, selected_certs.size());
-}
-
-// Verify that CertRequestInfo with empty |cert_authorities| matches all
-// issuers, rather than no issuers.
-TEST(ClientCertStoreImplTest, AllIssuersAllowed) {
- scoped_refptr<X509Certificate> cert(
- ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem"));
- ASSERT_TRUE(cert);
-
- std::vector<scoped_refptr<X509Certificate> > certs;
- certs.push_back(cert);
- scoped_refptr<SSLCertRequestInfo> request(new SSLCertRequestInfo());
-
- ClientCertStoreImpl store;
- std::vector<scoped_refptr<X509Certificate> > selected_certs;
- bool rv = store.SelectClientCerts(certs, *request, &selected_certs);
- EXPECT_TRUE(rv);
- ASSERT_EQ(1u, selected_certs.size());
- EXPECT_TRUE(selected_certs[0]->Equals(cert));
-}
-
-// Verify that certificates are correctly filtered against CertRequestInfo with
-// |cert_authorities| containing only |authority_1_DN|.
-TEST(ClientCertStoreImplTest, CertAuthorityFiltering) {
- scoped_refptr<X509Certificate> cert_1(
- ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem"));
- ASSERT_TRUE(cert_1);
- scoped_refptr<X509Certificate> cert_2(
- ImportCertFromFile(GetTestCertsDirectory(), "client_2.pem"));
- ASSERT_TRUE(cert_2);
-
- std::vector<std::string> authority_1(
- 1, std::string(reinterpret_cast<const char*>(kAuthority1DN),
- sizeof(kAuthority1DN)));
- std::vector<std::string> authority_2(
- 1, std::string(reinterpret_cast<const char*>(kAuthority2DN),
- sizeof(kAuthority2DN)));
- EXPECT_TRUE(cert_1->IsIssuedByEncoded(authority_1));
- EXPECT_FALSE(cert_1->IsIssuedByEncoded(authority_2));
- EXPECT_TRUE(cert_2->IsIssuedByEncoded(authority_2));
- EXPECT_FALSE(cert_2->IsIssuedByEncoded(authority_1));
-
- std::vector<scoped_refptr<X509Certificate> > certs;
- certs.push_back(cert_1);
- certs.push_back(cert_2);
- scoped_refptr<SSLCertRequestInfo> request(new SSLCertRequestInfo());
- request->cert_authorities = authority_1;
-
- ClientCertStoreImpl store;
- std::vector<scoped_refptr<X509Certificate> > selected_certs;
- bool rv = store.SelectClientCerts(certs, *request, &selected_certs);
- EXPECT_TRUE(rv);
- ASSERT_EQ(1u, selected_certs.size());
- EXPECT_TRUE(selected_certs[0]->Equals(cert_1));
-}
-
-#if defined(OS_MACOSX) && !defined(OS_IOS)
-// Verify that the preferred cert gets filtered out when it doesn't match the
-// server criteria.
-TEST(ClientCertStoreImplTest, FilterOutThePreferredCert) {
- scoped_refptr<X509Certificate> cert_1(
- ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem"));
- ASSERT_TRUE(cert_1);
-
- std::vector<std::string> authority_2(
- 1, std::string(reinterpret_cast<const char*>(kAuthority2DN),
- sizeof(kAuthority2DN)));
- EXPECT_FALSE(cert_1->IsIssuedByEncoded(authority_2));
-
- std::vector<scoped_refptr<X509Certificate> > certs;
- scoped_refptr<SSLCertRequestInfo> request(new SSLCertRequestInfo());
- request->cert_authorities = authority_2;
-
- ClientCertStoreImpl store;
- std::vector<scoped_refptr<X509Certificate> > selected_certs;
- bool rv = store.SelectClientCertsGivenPreferred(cert_1, certs, *request,
- &selected_certs);
- EXPECT_TRUE(rv);
- EXPECT_EQ(0u, selected_certs.size());
-}
-
-// Verify that the preferred cert takes the first position in the output list,
-// when it does not get filtered out.
-TEST(ClientCertStoreImplTest, PreferredCertGoesFirst) {
- scoped_refptr<X509Certificate> cert_1(
- ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem"));
- ASSERT_TRUE(cert_1);
- scoped_refptr<X509Certificate> cert_2(
- ImportCertFromFile(GetTestCertsDirectory(), "client_2.pem"));
- ASSERT_TRUE(cert_2);
-
- std::vector<scoped_refptr<X509Certificate> > certs;
- certs.push_back(cert_2);
- scoped_refptr<SSLCertRequestInfo> request(new SSLCertRequestInfo());
-
- ClientCertStoreImpl store;
- std::vector<scoped_refptr<X509Certificate> > selected_certs;
- bool rv = store.SelectClientCertsGivenPreferred(cert_1, certs, *request,
- &selected_certs);
- EXPECT_TRUE(rv);
- ASSERT_EQ(2u, selected_certs.size());
- EXPECT_TRUE(selected_certs[0]->Equals(cert_1));
- EXPECT_TRUE(selected_certs[1]->Equals(cert_2));
-}
-#endif
-
-} // namespace net
« no previous file with comments | « net/base/client_cert_store_impl_nss.cc ('k') | net/base/client_cert_store_impl_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698