net/base/DEPS - Issue 12680003: net: split net/ssl out of net/base

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/DEPS

Issue 12680003: net: split net/ssl out of net/base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "-net",

	3 "+net/base",
	wtc 2013/03/12 23:14:37 Does this mean we cannot include any headers in ne Does this mean we cannot include any headers in net except the headers in net/base? tfarina 2013/03/12 23:55:28 no, it means net/base can only include headers fro Show quoted text On 2013/03/12 23:14:37, wtc wrote: > > Does this mean we cannot include any headers in net except > the headers in net/base? no, it means net/base can only include headers from within net/base, i.e., it won't be possible to include net/ftp in net/base/address_list.h (picked randomly). Paweł Hajdan Jr. 2013/03/13 22:59:52 I've used this to make sure I'm not making net/bas Show quoted text On 2013/03/12 23:14:37, wtc wrote: > > Does this mean we cannot include any headers in net except > the headers in net/base? I've used this to make sure I'm not making net/base accidentally use net/ssl . However, there are many existing violation of the above, like includes of net/dns, http, android, url_request that I think it's not worth to add the above with a pretty large whitelist.
	4

2 "+third_party/npapi",	5 "+third_party/npapi",

3 "+third_party/zlib",	6 "+third_party/zlib",

4 "+grit", # For generated headers	7 "+grit", # For generated headers

5 ]	8 ]

OLD	NEW