Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1267953002: Reenable code recompilation verification. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reenable code recompilation verification. BUG=chromium:516304 LOG=N Committed: https://crrev.com/85fff2dca47a62abc83049a5d79477e11c890c98 Cr-Commit-Position: refs/heads/master@{#30210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/objects-debug.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267953002/1
5 years, 4 months ago (2015-08-03 13:36:43 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4638)
5 years, 4 months ago (2015-08-03 13:40:30 UTC) #6
Yang
5 years, 4 months ago (2015-08-03 13:58:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267953002/1
5 years, 4 months ago (2015-08-03 18:11:06 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-03 18:11:07 UTC) #12
Yang
On 2015/08/03 18:11:07, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 4 months ago (2015-08-04 08:27:48 UTC) #13
mvstanton
lgtm
5 years, 4 months ago (2015-08-18 06:56:51 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267953002/1
5 years, 4 months ago (2015-08-18 07:21:27 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 07:48:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267953002/1
5 years, 4 months ago (2015-08-18 07:50:39 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 07:53:51 UTC) #21
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 07:54:02 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85fff2dca47a62abc83049a5d79477e11c890c98
Cr-Commit-Position: refs/heads/master@{#30210}

Powered by Google App Engine
This is Rietveld 408576698