media/filters/ffmpeg_audio_decoder.h - Issue 126793002: Add Stop() to AudioDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_audio_decoder.h

Issue 126793002: Add Stop() to AudioDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Call reset and stop callbacks after releasing |lock_| Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_audio_decoder.h

diff --git a/media/filters/ffmpeg_audio_decoder.h b/media/filters/ffmpeg_audio_decoder.h

index d143433daa6df38d56fbbce6734e2bc1f29d8e9b..d89b1fac8fff87c5d47857f117a539a9b365fdf1 100644

--- a/media/filters/ffmpeg_audio_decoder.h

+++ b/media/filters/ffmpeg_audio_decoder.h

@@ -45,6 +45,7 @@ class MEDIA_EXPORT FFmpegAudioDecoder : public AudioDecoder {

virtual ChannelLayout channel_layout() OVERRIDE;

virtual int samples_per_second() OVERRIDE;

virtual void Reset(const base::Closure& closure) OVERRIDE;

+ virtual void Stop(const base::Closure& closure) OVERRIDE;

// Callback called from within FFmpeg to allocate a buffer based on

// the dimensions of |codec_context|. See AVCodecContext.get_buffer2