Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 126793002: Add Stop() to AudioDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extraneous #include Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index f9b314d2ec2536ff43b18fd15ae2db222f61a4a0..4cb1f9d3c0b93a1d9ef098081f3fb46f96b6ad07 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -147,8 +147,8 @@ void AudioRendererImpl::DoFlush_Locked() {
DCHECK_EQ(state_, kPaused);
if (decrypting_demuxer_stream_) {
- decrypting_demuxer_stream_->Reset(BindToCurrentLoop(
- base::Bind(&AudioRendererImpl::ResetDecoder, weak_this_)));
+ decrypting_demuxer_stream_->Reset(
+ base::Bind(&AudioRendererImpl::ResetDecoder, weak_this_));
return;
}
@@ -157,31 +157,52 @@ void AudioRendererImpl::DoFlush_Locked() {
void AudioRendererImpl::ResetDecoder() {
DCHECK(task_runner_->BelongsToCurrentThread());
- decoder_->Reset(BindToCurrentLoop(
- base::Bind(&AudioRendererImpl::ResetDecoderDone, weak_this_)));
+ decoder_->Reset(base::Bind(&AudioRendererImpl::ResetDecoderDone, weak_this_));
}
void AudioRendererImpl::ResetDecoderDone() {
- base::AutoLock auto_lock(lock_);
- if (state_ == kStopped)
- return;
-
- DCHECK_EQ(state_, kPaused);
- DCHECK(!flush_cb_.is_null());
+ DCHECK(task_runner_->BelongsToCurrentThread());
+ {
+ base::AutoLock auto_lock(lock_);
+ if (state_ == kStopped)
+ return;
- audio_time_buffered_ = kNoTimestamp();
- current_time_ = kNoTimestamp();
- received_end_of_stream_ = false;
- rendered_end_of_stream_ = false;
- preroll_aborted_ = false;
+ DCHECK_EQ(state_, kPaused);
+ DCHECK(!flush_cb_.is_null());
- earliest_end_time_ = now_cb_.Run();
- splicer_->Reset();
- algorithm_->FlushBuffers();
+ audio_time_buffered_ = kNoTimestamp();
+ current_time_ = kNoTimestamp();
+ received_end_of_stream_ = false;
+ rendered_end_of_stream_ = false;
+ preroll_aborted_ = false;
+ earliest_end_time_ = now_cb_.Run();
+ splicer_->Reset();
+ algorithm_->FlushBuffers();
+ }
base::ResetAndReturn(&flush_cb_).Run();
}
+void AudioRendererImpl::StopDecoderDone() {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+ {
+ base::AutoLock auto_lock(lock_);
+ if (state_ == kStopped)
+ return;
+
+ DCHECK(!stop_cb_.is_null());
+ DCHECK(init_cb_.is_null());
+
+ ChangeState_Locked(kStopped);
+ algorithm_.reset();
+ init_cb_.Reset();
+ underflow_cb_.Reset();
+ time_cb_.Reset();
+ flush_cb_.Reset();
+ }
+ base::ResetAndReturn(&stop_cb_).Run();
+}
+
void AudioRendererImpl::Stop(const base::Closure& callback) {
DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK(!callback.is_null());
@@ -194,17 +215,15 @@ void AudioRendererImpl::Stop(const base::Closure& callback) {
sink_ = NULL;
}
- {
- base::AutoLock auto_lock(lock_);
- ChangeState_Locked(kStopped);
- algorithm_.reset(NULL);
- init_cb_.Reset();
- underflow_cb_.Reset();
- time_cb_.Reset();
- flush_cb_.Reset();
+ stop_cb_ = callback;
+
+ if (decoder_) {
+ DCHECK(task_runner_->BelongsToCurrentThread());
+ decoder_->Stop(base::Bind(&AudioRendererImpl::StopDecoderDone, weak_this_));
+ return;
}
- callback.Run();
+ StopDecoderDone();
}
void AudioRendererImpl::Preroll(base::TimeDelta time,
« no previous file with comments | « media/filters/audio_renderer_impl.h ('k') | media/filters/audio_renderer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698