Pass GpuMemoryBuffer backed VideoFrame from browser to renderer processes

content/browser/renderer_host/media/video_capture_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 298 matching lines @@
     }
     scoped_ptr<base::DictionaryValue> metadata(new base::DictionaryValue());
     frame->metadata()->MergeInternalValuesInto(metadata.get());
 
     for (const auto& client : controller_clients_) {
       if (client->session_closed || client->paused)
         continue;
 
       CHECK((frame->IsMappable() &&
              frame->format() == media::PIXEL_FORMAT_I420) ||
-            (!frame->IsMappable() && frame->HasTextures() &&
-             frame->format() == media::PIXEL_FORMAT_ARGB))
+            (frame->HasTextures() &&
+             (frame->format() == media::PIXEL_FORMAT_ARGB ||
+              frame->format() == media::PIXEL_FORMAT_I420)))
           << "Format and/or storage type combination not supported (received: "
           << media::VideoPixelFormatToString(frame->format()) << ")";
 
-      if (frame->HasTextures()) {
-        DCHECK(frame->coded_size() == frame->visible_rect().size())
-            << "Textures are always supposed to be tightly packed.";
-        DCHECK_EQ(1u, VideoFrame::NumPlanes(frame->format()));
-      } else if (frame->format() == media::PIXEL_FORMAT_I420) {
-        const bool is_new_buffer =
-            client->known_buffers.insert(buffer_id).second;
-        if (is_new_buffer) {
-          // On the first use of a buffer on a client, share the memory handle.
-          size_t memory_size = 0;
-          base::SharedMemoryHandle remote_handle = buffer_pool_->ShareToProcess(
-              buffer_id, client->render_process_handle, &memory_size);
+      // On the first use of a buffer on a client, share the memory handles.
+      const bool is_new_buffer = client->known_buffers.insert(buffer_id).second;
+      if (is_new_buffer) {
+        if (frame->HasTextures() &&
+            frame->format() == media::PIXEL_FORMAT_I420) {
+          std::vector<gfx::GpuMemoryBufferHandle> gmb_handles(
+              VideoFrame::NumPlanes(frame->format()));
+          for (size_t i = 0; i < gmb_handles.size(); ++i)
+            buffer_pool_->ShareToProcess(
+                buffer_id, i, client->render_process_handle, &gmb_handles[i]);
+
+          client->event_handler->OnGpuMemoryBufferCreated(
+              client->controller_id, gmb_handles, buffer->dimensions(),
+              buffer_id);
+        } else if (frame->IsMappable()) {

[mcasas, 2015/08/21 03:57:25]

Please keep the DCHECKs for the case of opaque texture ARGB
that were before in l.325+326. And in the previous code, in that
case |buffer_id| was not inserted...

[emircan, 2015/08/22 03:13:26]

Done. I restructured this method to make it clear on the cases we handle.

+          base::SharedMemoryHandle remote_handle;
+          buffer_pool_->ShareToProcess(
+              buffer_id, 0, client->render_process_handle, &remote_handle);
+
           client->event_handler->OnBufferCreated(
-              client->controller_id, remote_handle, memory_size, buffer_id);
+              client->controller_id, remote_handle, buffer->mapped_size(),
+              buffer_id);
         }
       }
 
       client->event_handler->OnBufferReady(client->controller_id,
                                            buffer_id,
                                            frame,
                                            timestamp);
       const bool inserted =
           client->active_buffers.insert(std::make_pair(buffer_id, frame))
               .second;
@@ skipping 83 matching lines @@
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   int active_client_count = 0;
   for (ControllerClient* client : controller_clients_) {
     if (!client->paused)
       ++active_client_count;
   }
   return active_client_count;
 }
 
 }  // namespace content