Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: google_apis/gaia/oauth2_token_service_delegate.cc

Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/gaia/oauth2_token_service_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gaia/oauth2_token_service_delegate.cc
diff --git a/google_apis/gaia/oauth2_token_service_delegate.cc b/google_apis/gaia/oauth2_token_service_delegate.cc
index afe6e6ffaf1c603687ce64f556f2d72757b66ad7..2f976145ea1ee0d03451ac5dc580b780ea3df3af 100644
--- a/google_apis/gaia/oauth2_token_service_delegate.cc
+++ b/google_apis/gaia/oauth2_token_service_delegate.cc
@@ -46,6 +46,12 @@ void OAuth2TokenServiceDelegate::RemoveObserver(
observer_list_.RemoveObserver(observer);
}
+// static
+bool OAuth2TokenServiceDelegate::IsError(const GoogleServiceAuthError& error) {
+ // TODO(rogerta): should we distinguish between transient and persistent?
+ return error.state() != GoogleServiceAuthError::NONE;
+}
+
void OAuth2TokenServiceDelegate::StartBatchChanges() {
++batch_change_depth_;
if (batch_change_depth_ == 1)
@@ -95,6 +101,11 @@ net::URLRequestContextGetter* OAuth2TokenServiceDelegate::GetRequestContext()
return nullptr;
}
+bool OAuth2TokenServiceDelegate::RefreshTokenHasError(
+ const std::string& account_id) const {
+ return false;
+}
+
std::vector<std::string> OAuth2TokenServiceDelegate::GetAccounts() {
return std::vector<std::string>();
}
« no previous file with comments | « google_apis/gaia/oauth2_token_service_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698