components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm - Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm

Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h ('k') | google_apis/gaia/fake_oauth2_token_service_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm

diff --git a/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm b/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm

index c9cc2b8601814c1926e4c0bf16387a066dfc1c3a..aba0cadcef7a4f4e0b9a252e6f27a102a3d0a19c 100644

--- a/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm

+++ b/components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm

@@ -310,6 +310,14 @@ bool ProfileOAuth2TokenServiceIOSDelegate::RefreshTokenIsAvailable(

return accounts_.count(account_id) > 0;

}

+bool ProfileOAuth2TokenServiceIOSDelegate::RefreshTokenHasError(

+ const std::string& account_id) const {

+ DCHECK(thread_checker_.CalledOnValidThread());

+ auto it = accounts_.find(account_id);

+ // TODO(rogerta): should we distinguish between transient and persistent?

+ return it == accounts_.end() ? false : IsError(it->second->GetAuthStatus());

void ProfileOAuth2TokenServiceIOSDelegate::UpdateAuthError(

const std::string& account_id,

const GoogleServiceAuthError& error) {