components/signin/core/browser/account_reconcilor.h - Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_reconcilor.h

Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/oauth2_token_service_delegate_android.cc ('k') | components/signin/core/browser/account_reconcilor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/account_reconcilor.h

diff --git a/components/signin/core/browser/account_reconcilor.h b/components/signin/core/browser/account_reconcilor.h

index a6feb7444d2c03485ba370b761f3b419da9d4cfe..c0d5546d303b2a14312f2f524c202553accbf18c 100644

--- a/components/signin/core/browser/account_reconcilor.h

+++ b/components/signin/core/browser/account_reconcilor.h

@@ -94,6 +94,8 @@ class AccountReconcilor : public KeyedService,

StartReconcileWithSessionInfoExpiredDefault);

FRIEND_TEST_ALL_PREFIXES(AccountReconcilorTest,

AddAccountToCookieCompletedWithBogusAccount);

+ FRIEND_TEST_ALL_PREFIXES(AccountReconcilorTest, NoLoopWithBadPrimary);

+ FRIEND_TEST_ALL_PREFIXES(AccountReconcilorTest, WontMergeAccountsWithError);

// Register and unregister with dependent services.

void RegisterWithSigninManager();