chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc - Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc

Issue 1267843003: Fix reconcilor loop when the primary account is in an auth error state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/account_reconcilor_unittest.cc ('K') | « chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h ('k') | chrome/browser/signin/oauth2_token_service_delegate_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc

diff --git a/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc b/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc

index be5c295dc4682174b3286f7e351015248cec5dfc..129dd74baee368178d299ec1c8d95a98aea7e9ca 100644

--- a/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc

+++ b/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc

@@ -172,6 +172,15 @@ MutableProfileOAuth2TokenServiceDelegate::CreateAccessTokenFetcher(

return new OAuth2AccessTokenFetcherImpl(consumer, getter, refresh_token);

}

+bool MutableProfileOAuth2TokenServiceDelegate::RefreshTokenHasError(

+ const std::string& account_id) const {

+ auto it = refresh_tokens_.find(account_id);

+ // TODO(rogerta): should we distinguish between transient and persistent?

+ return it == refresh_tokens_.end()

+ ? false

+ : it->second->GetAuthStatus().state() != GoogleServiceAuthError::NONE;

void MutableProfileOAuth2TokenServiceDelegate::UpdateAuthError(

const std::string& account_id,

const GoogleServiceAuthError& error) {