Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1267783002: X87: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. port 597da503220ab2a632453d2e3a915e9824d6d592 (r29910). original commit message: Changes the interpreter to use a BytecodeArray pointer and an offset to avoid having an inner pointer to a BytecodeArray object in registers during dispatch. BUG= Committed: https://crrev.com/b3dd6de50860f1f7bdbf0d455f7c1688ed2cdb7d Cr-Commit-Position: refs/heads/master@{#29942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/x87/linkage-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-07-31 03:10:13 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-07-31 03:50:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267783002/1
5 years, 4 months ago (2015-07-31 03:50:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 05:22:19 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 05:22:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3dd6de50860f1f7bdbf0d455f7c1688ed2cdb7d
Cr-Commit-Position: refs/heads/master@{#29942}

Powered by Google App Engine
This is Rietveld 408576698