Ship --harmony-new-target

Ship --harmony-new-target

BUG=v8:3887
LOG=y

Committed: https://crrev.com/61805178c25ba0b64731c5ff667e0074480ffd70
Cr-Commit-Position: refs/heads/master@{#30013}

[adamk, 2015-08-03 21:06:04]

adamk@chromium.org changed reviewers:
+ rossberg@chromium.org

[adamk, 2015-08-03 21:22:06]

Looks like this needs some debugger work, no need to review till I get a handle
on that.

[adamk, 2015-08-03 21:42:47]

adamk@chromium.org changed reviewers:
+ yangguo@chromium.org

[adamk, 2015-08-03 21:42:48]

Looking more closely, it looks like the issue is that 'new.target' now gets
reflected in the scope mirror. So the question is, what do we want to do about
that? What do we do with other implicitly-passed things like 'arguments'?

[adamk, 2015-08-03 22:41:04]

See https://codereview.chromium.org/1259183005/ for one way around this problem:
it makes the new.target variable internal (prepending its name with a '.'),
which seems, as a side-effect, to hide it from the debugger.

[adamk, 2015-08-03 23:25:58]

To talk to myself a little bit more: it looks like we already have kind of
strange behavior for 'arguments' in the debugger. If there's an eval or with, it
shows up. So we could do the same with new.target. My main worry is that it'll
confuse people. Maybe it's ok to hide it for now, by that logic?

[rossberg, 2015-08-04 12:42:48]

LGTM, I'm okay with this.

[Yang, 2015-08-04 12:43:44]

On 2015/08/04 12:42:48, rossberg wrote:
> LGTM, I'm okay with this.

Yes, I think hiding it from the debugger is fine for now.

[adamk, 2015-08-04 17:33:46]

The CQ bit was checked by adamk@chromium.org

[adamk, 2015-08-04 17:33:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1267773009/#ps60001
(title: "Removed now-unnecessary test changes")

[commit-bot: I haz the power, 2015-08-04 17:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267773009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267773009/60001

[commit-bot: I haz the power, 2015-08-04 18:01:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-04 18:02:18]

Patchset 4 (id:??) landed as
https://crrev.com/61805178c25ba0b64731c5ff667e0074480ffd70
Cr-Commit-Position: refs/heads/master@{#30013}