Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: pylib/gyp/generator/msvs.py

Issue 1267703004: Added msvs_target_platform_version and msvs_target_platform_minversion for winrt compilation (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/generator/msvs.py
diff --git a/pylib/gyp/generator/msvs.py b/pylib/gyp/generator/msvs.py
index 1338790ef68f9cae0df435bd358452e8cb19edb8..4ce82ec8f43d7a6bc3347a4e8be02f23af275e23 100644
--- a/pylib/gyp/generator/msvs.py
+++ b/pylib/gyp/generator/msvs.py
@@ -87,6 +87,8 @@ generator_additional_non_configuration_keys = [
'msvs_requires_importlibrary',
'msvs_enable_winphone',
'msvs_application_type_revision',
+ 'msvs_target_platform_version',
+ 'msvs_target_platform_minversion',
]
@@ -2644,6 +2646,14 @@ def _GetMSBuildGlobalProperties(spec, guid, gyp_file_name):
else:
properties[0].append(['ApplicationTypeRevision', '8.1'])
+ if spec.get('msvs_target_platform_version'):
+ tar_plat_ver = spec.get('msvs_target_platform_version')
scottmg 2015/08/12 04:12:20 I don't like "tar" and "plat", "ver" is ok if it h
coop 2015/08/12 16:47:21 YAY! I am so glad you said this. I originally ha
+ properties[0].append(['WindowsTargetPlatformVersion', tar_plat_ver])
+ if spec.get('msvs_target_platform_minversion'):
+ tar_plat_mver = spec.get('msvs_target_platform_minversion')
+ properties[0].append(['WindowsTargetPlatformMinVersion', tar_plat_mver])
+ else:
+ properties[0].append(['WindowsTargetPlatformMinVersion', tar_plat_ver])
if spec.get('msvs_enable_winphone'):
properties[0].append(['ApplicationType', 'Windows Phone'])
else:

Powered by Google App Engine
This is Rietveld 408576698