Added msvs_target_platform_version and msvs_target_platform_minversion for winrt compilation

pylib/gyp/generator/msvs.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import ntpath
 import os
 import posixpath
 import re
 import subprocess
@@ skipping 69 matching lines @@
     'msvs_shard',
     'msvs_external_builder',
     'msvs_external_builder_out_dir',
     'msvs_external_builder_build_cmd',
     'msvs_external_builder_clean_cmd',
     'msvs_external_builder_clcompile_cmd',
     'msvs_enable_winrt',
     'msvs_requires_importlibrary',
     'msvs_enable_winphone',
     'msvs_application_type_revision',
+    'msvs_target_platform_version',
+    'msvs_target_platform_minversion',
 ]
 
 
 # List of precompiled header related keys.
 precomp_keys = [
     'msvs_precompiled_header',
     'msvs_precompiled_source',
 ]
 
 
@@ skipping 2537 matching lines @@
 
   if spec.get('msvs_enable_winrt'):
     properties[0].append(['DefaultLanguage', 'en-US'])
     properties[0].append(['AppContainerApplication', 'true'])
     if spec.get('msvs_application_type_revision'):
       app_type_revision = spec.get('msvs_application_type_revision')
       properties[0].append(['ApplicationTypeRevision', app_type_revision])
     else:
       properties[0].append(['ApplicationTypeRevision', '8.1'])
 
+    if spec.get('msvs_target_platform_version'):
+      tar_plat_ver = spec.get('msvs_target_platform_version')

[scottmg, 2015/08/12 04:12:20]

I don't like "tar" and "plat", "ver" is ok if it helps squish it in. (I know it
makes the append lines too long, but it's better to have a readable name.)

[coop, 2015/08/12 16:47:21]

YAY!  I am so glad you said this.  I originally had them as proper/clear names
but I thought you would bust me for exceeding the column line limits and I
changed it.  I will fix this back up.

+      properties[0].append(['WindowsTargetPlatformVersion', tar_plat_ver])
+      if spec.get('msvs_target_platform_minversion'):
+        tar_plat_mver = spec.get('msvs_target_platform_minversion')
+        properties[0].append(['WindowsTargetPlatformMinVersion', tar_plat_mver])
+      else:
+        properties[0].append(['WindowsTargetPlatformMinVersion', tar_plat_ver])
     if spec.get('msvs_enable_winphone'):
       properties[0].append(['ApplicationType', 'Windows Phone'])
     else:
       properties[0].append(['ApplicationType', 'Windows Store'])
 
   return properties
 
 def _GetMSBuildConfigurationDetails(spec, build_file):
   properties = {}
   for name, settings in spec['configurations'].iteritems():
@@ skipping 774 matching lines @@
   action_spec.extend(
       # TODO(jeanluc) 'Document' for all or just if as_sources?
       [['FileType', 'Document'],
        ['Command', command],
        ['Message', description],
        ['Outputs', outputs]
       ])
   if additional_inputs:
     action_spec.append(['AdditionalInputs', additional_inputs])
   actions_spec.append(action_spec)