Added msvs_target_platform_version and msvs_target_platform_minversion for winrt compilation

Added msvs_target_platform_version and  msvs_target_platform_minversion for winrt compilation

With the introduction of Windows 10 Universal applications, winrt app projects require target platform version information.  This change allows this value to customized in the GYP.

Patch from coopp@microsoft.com.

R=scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/81c2e5ff92af29bab61c982808076ddce3d200a2

[coop, 2015-08-03 19:52:39]

coopp@microsoft.com changed reviewers:
+ scottmg@chromium.org

[coop, 2015-08-03 19:52:39]

coopp@microsoft.com changed required reviewers:
+ scottmg@chromium.org

[coop, 2015-08-12 00:01:47]

Just re-pinging to keep this visible in your mailbox.

I know that you just got back from vacation and are getting up to speed again.
The 'back to work' process for me takes some time too :)

[scottmg, 2015-08-12 04:12:20]

https://codereview.chromium.org/1267703004/diff/1/pylib/gyp/generator/msvs.py
File pylib/gyp/generator/msvs.py (right):

https://codereview.chromium.org/1267703004/diff/1/pylib/gyp/generator/msvs.py...
pylib/gyp/generator/msvs.py:2650: tar_plat_ver =
spec.get('msvs_target_platform_version')
I don't like "tar" and "plat", "ver" is ok if it helps squish it in. (I know it
makes the append lines too long, but it's better to have a readable name.)

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt-target-platform-version.py (right):

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-target-platform-version.py:3: # Copyright (c)
2013 Google Inc. All rights reserved.
2015

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-target-platform-version.py:19: print 'This
test is not currently working on the bots:
https://code.google.com/p/gyp/issues/detail?id=466'
this is getting a bit silly :(

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
File test/win/winrt-target-platform-version/winrt-target-platform-version.gyp
(right):

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
test/win/winrt-target-platform-version/winrt-target-platform-version.gyp:1: #
Copyright (c) 2013 Google Inc. All rights reserved.
2015

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
test/win/winrt-target-platform-version/winrt-target-platform-version.gyp:48:
'msvs_settings': {
I don't think this does anything here?

[coop, 2015-08-12 16:47:21]

Updated with feedback.

https://codereview.chromium.org/1267703004/diff/1/pylib/gyp/generator/msvs.py
File pylib/gyp/generator/msvs.py (right):

https://codereview.chromium.org/1267703004/diff/1/pylib/gyp/generator/msvs.py...
pylib/gyp/generator/msvs.py:2650: tar_plat_ver =
spec.get('msvs_target_platform_version')
On 2015/08/12 04:12:20, scottmg wrote:
> I don't like "tar" and "plat", "ver" is ok if it helps squish it in. (I know
it
> makes the append lines too long, but it's better to have a readable name.)

YAY!  I am so glad you said this.  I originally had them as proper/clear names
but I thought you would bust me for exceeding the column line limits and I
changed it.  I will fix this back up.

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
File test/win/gyptest-link-enable-winrt-target-platform-version.py (right):

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-target-platform-version.py:3: # Copyright (c)
2013 Google Inc. All rights reserved.
On 2015/08/12 04:12:20, scottmg wrote:
> 2015

Done.

https://codereview.chromium.org/1267703004/diff/1/test/win/gyptest-link-enabl...
test/win/gyptest-link-enable-winrt-target-platform-version.py:19: print 'This
test is not currently working on the bots:
https://code.google.com/p/gyp/issues/detail?id=466'
On 2015/08/12 04:12:20, scottmg wrote:
> this is getting a bit silly :(

Agreed.

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
File test/win/winrt-target-platform-version/winrt-target-platform-version.gyp
(right):

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
test/win/winrt-target-platform-version/winrt-target-platform-version.gyp:1: #
Copyright (c) 2013 Google Inc. All rights reserved.
On 2015/08/12 04:12:20, scottmg wrote:
> 2015

Done.

https://codereview.chromium.org/1267703004/diff/1/test/win/winrt-target-platf...
test/win/winrt-target-platform-version/winrt-target-platform-version.gyp:48:
'msvs_settings': {
On 2015/08/12 04:12:20, scottmg wrote:
> I don't think this does anything here?

Done.

[scottmg, 2015-08-12 17:05:54]

otherwise lgtm

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
File pylib/gyp/generator/msvs.py (right):

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
pylib/gyp/generator/msvs.py:2651:
properties[0].append(['WindowsTargetPlatformVersion', target_platform_version])
you still need to maintain 80 col though :) maybe target_platform_version
aligned with the first '.

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
pylib/gyp/generator/msvs.py:2654:
properties[0].append(['WindowsTargetPlatformMinVersion',
target_platform_minversion])
same

[coop, 2015-08-12 20:03:44]

Formatted to meet 80 col requirements.

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
File pylib/gyp/generator/msvs.py (right):

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
pylib/gyp/generator/msvs.py:2651:
properties[0].append(['WindowsTargetPlatformVersion', target_platform_version])
On 2015/08/12 17:05:54, scottmg wrote:
> you still need to maintain 80 col though :) maybe target_platform_version
> aligned with the first '.

Done.

https://codereview.chromium.org/1267703004/diff/20001/pylib/gyp/generator/msv...
pylib/gyp/generator/msvs.py:2654:
properties[0].append(['WindowsTargetPlatformMinVersion',
target_platform_minversion])
On 2015/08/12 17:05:54, scottmg wrote:
> same

Done.

[scottmg, 2015-08-12 20:13:55]

Committed patchset #3 (id:40001) manually as
81c2e5ff92af29bab61c982808076ddce3d200a2.