Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: ui/events/gesture_detection/gesture_configuration_android.cc

Issue 1267693004: Disable tap suppression logic for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable for webview Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/gesture_detection/gesture_configuration_android.cc
diff --git a/ui/events/gesture_detection/gesture_configuration_android.cc b/ui/events/gesture_detection/gesture_configuration_android.cc
index 4922559763277d3197d63f1a4dd12221deb69ef8..30c43d99a46fc2d8d518464ddffc7037a2620b71 100644
--- a/ui/events/gesture_detection/gesture_configuration_android.cc
+++ b/ui/events/gesture_detection/gesture_configuration_android.cc
@@ -52,6 +52,15 @@ class GestureConfigurationAndroid : public GestureConfiguration {
ViewConfiguration::GetMinScalingTouchMajorInDips());
set_show_press_delay_in_ms(ViewConfiguration::GetTapTimeoutInMs());
set_span_slop(ViewConfiguration::GetTouchSlopInDips() * 2.f);
+ set_fling_touchscreen_tap_suppression_enabled(true);
+ set_fling_touchpad_tap_suppression_enabled(false);
tdresser 2015/08/04 12:20:50 If you plug in an external touchpad on Android, do
jdduke (slow) 2015/08/04 17:19:25 I don't actually know =/, I was about to order an
+ set_fling_max_cancel_to_down_time_in_ms(
+ ViewConfiguration::GetTapTimeoutInMs());
+ set_fling_max_tap_gap_time_in_ms(
+ ViewConfiguration::GetLongPressTimeoutInMs());
+ // There is no "semi" longpress on Android, just use the longpress value.
tdresser 2015/08/04 12:20:50 I think it might be clearer to set this to 0.
jdduke (slow) 2015/08/04 17:19:25 Yeah, I went ahead and removed this line, and chan
+ set_semi_long_press_time_in_ms(
+ ViewConfiguration::GetLongPressTimeoutInMs());
}
friend struct DefaultSingletonTraits<GestureConfigurationAndroid>;

Powered by Google App Engine
This is Rietveld 408576698