chrome/browser/notifications/platform_notification_service_impl.cc - Issue 1267673003: Plumb Blink notification actions to button UI on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1267673003: Plumb Blink notification actions to button UI on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Notifications database integration Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/notifications/platform_notification_service_unittest.cc » ('j') | chrome/browser/notifications/platform_notification_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index da15f65a863f65c6f47c28b96dcb36ded24a7313..e4b99690826c10f8a822377a821bfaf586384529 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -335,6 +335,12 @@ Notification PlatformNotificationServiceImpl::CreateNotificationFromData(

notification.set_vibration_pattern(notification_data.vibration_pattern);

notification.set_silent(notification_data.silent);

+ std::vector<message_center::ButtonInfo> buttons;

+ for (const auto& action : notification_data.actions)

+ buttons.push_back(message_center::ButtonInfo(action.title));

+ notification.set_buttons(buttons);

// Web Notifications do not timeout.

notification.set_never_timeout(true);