content/browser/notifications/notification_message_filter.cc - Issue 1267673003: Plumb Blink notification actions to button UI on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 1267673003: Plumb Blink notification actions to button UI on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix size_t Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_data_unittest.cc ('k') | content/child/notifications/notification_data_conversions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index 8f22f429515aa8c3fca0dc42b9fcdab6b63b5808..32691565d7f90140b1b43ec38b61f35bcdcf13fe 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -8,6 +8,7 @@

#include "content/browser/bad_message.h"

#include "content/browser/notifications/page_notification_delegate.h"

#include "content/browser/notifications/platform_notification_context_impl.h"

+#include "content/common/notification_constants.h"

#include "content/common/platform_notification_messages.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_thread.h"

@@ -35,6 +36,10 @@ PlatformNotificationData SanitizeNotificationData(

std::max(kMinimumVibrationDurationMs, pattern));

}

+ // Ensure there aren't more actions than supported.

+ if (sanitized_data.actions.size() > kPlatformNotificationMaxActions)

+ sanitized_data.actions.resize(kPlatformNotificationMaxActions);

return sanitized_data;

}