content/common/platform_notification_messages.h - Issue 1267673003: Plumb Blink notification actions to button UI on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/platform_notification_messages.h

Issue 1267673003: Plumb Blink notification actions to button UI on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions_unittest.cc ('K') | « content/child/notifications/notification_data_conversions_unittest.cc ('k') | content/content_common.gypi » ('j') | content/public/common/platform_notification_action.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/platform_notification_messages.h

diff --git a/content/common/platform_notification_messages.h b/content/common/platform_notification_messages.h

index 009ff619e5c18156a36ff19e090111469e06be1f..1cdb2c1fa72b27fff147b5662525cf77790f34eb 100644

--- a/content/common/platform_notification_messages.h

+++ b/content/common/platform_notification_messages.h

@@ -35,6 +35,11 @@ IPC_ENUM_TRAITS_MAX_VALUE(

content::PlatformNotificationData::NotificationDirection,

content::PlatformNotificationData::NotificationDirectionLast)

+IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationAction)

+ IPC_STRUCT_TRAITS_MEMBER(action)

+ IPC_STRUCT_TRAITS_MEMBER(title)

+IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationData)

IPC_STRUCT_TRAITS_MEMBER(title)

IPC_STRUCT_TRAITS_MEMBER(direction)

@@ -45,6 +50,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::PlatformNotificationData)

IPC_STRUCT_TRAITS_MEMBER(vibration_pattern)

IPC_STRUCT_TRAITS_MEMBER(silent)

IPC_STRUCT_TRAITS_MEMBER(data)

+ IPC_STRUCT_TRAITS_MEMBER(actions)

Peter Beverloo 2015/07/30 17:02:05 The receiving side (browser) must verify that the

johnme 2015/07/31 18:21:31 Done (SanitizeNotificationData in notification_mes

IPC_STRUCT_TRAITS_END()

// Messages sent from the browser to the renderer.