Issue 1267623004: Revert of Modifying TextBlobCacheTest to use SkRandomScalerContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1267623004: Revert of Modifying TextBlobCacheTest to use SkRandomScalerContext (Closed)

Created:
5 years, 4 months ago by joshualitt

Modified:
5 years, 4 months ago

Reviewers:
bungeman-skia, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Modifying TextBlobCacheTest to use SkRandomScalerContext (patchset #3 id:40001 of https://codereview.chromium.org/1266003002/) Reason for revert: breaking android Original issue's description: > Modifying TextBlobCacheTest to use SkRandomScalerContext > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/adcdca86ce425cf8c28bfad311cef028df756ee8 TBR=bungeman@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/bdc91a7fdb100da9321c1c17fae912949ccb60b2

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -116 lines)			Patch
M	src/core/SkScalerContext.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/fonts/SkRandomScalerContext.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/fonts/SkRandomScalerContext.cpp	View	7 chunks	+58 lines, -92 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/GrBatchAtlas.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/gpu/GrBatchFontCache.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/TextBlobCacheTest.cpp	View	4 chunks	+2 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Modifying TextBlobCacheTest to use SkRandomScalerContext

5 years, 4 months ago (2015-07-31 14:54:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267623004/1

5 years, 4 months ago (2015-07-31 14:55:02 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-31 14:55:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bdc91a7fdb100da9321c1c17fae912949ccb60b2

Expand Messages | Collapse Messages