Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 12676028: Fix licensecheck on third_party/cld (Closed)

Created:
7 years, 9 months ago by Takashi Toyoshima
Modified:
7 years, 9 months ago
Reviewers:
MAD
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Fix licensecheck on third_party/cld - Remove unused files - Update license description - Remove them from suppression list BUG=98120 TEST=tools/checklicenses/checklicenses.py third_party/cld Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190442

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -121 lines) Patch
M third_party/cld/encodings/compact_lang_det/generated/compact_lang_det_generated_ctjkvz_0.cc View 1 chunk +3 lines, -1 line 0 comments Download
D third_party/cld/encodings/compact_lang_det/subsetsequence_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/cld/encodings/compact_lang_det/win/cld_utf8utils_google3.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Takashi Toyoshima
Hi mad, Could you take a look this? I'll fix internal generators, but for now ...
7 years, 9 months ago (2013-03-24 19:37:03 UTC) #1
MAD
lgtm
7 years, 9 months ago (2013-03-25 13:05:49 UTC) #2
Takashi Toyoshima
7 years, 9 months ago (2013-03-25 18:24:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r190442.

Powered by Google App Engine
This is Rietveld 408576698