Adding policy support to the new network configuration stack.

chrome/browser/chromeos/extensions/networking_private_api.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/networking_private_api.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "chrome/browser/extensions/extension_function_registry.h"
@@ skipping 19 matching lines @@
 
 bool NetworkingPrivateGetPropertiesFunction::RunImpl() {
   scoped_ptr<api::GetProperties::Params> params =
       api::GetProperties::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
   // The |network_guid| parameter is storing the service path.
   std::string service_path = params->network_guid;
 
   ManagedNetworkConfigurationHandler::Get()->GetProperties(
       service_path,
-      base::Bind(
-          &NetworkingPrivateGetPropertiesFunction::GetPropertiesSuccess,
-          this),
+      base::Bind(&NetworkingPrivateGetPropertiesFunction::GetPropertiesSuccess,
+                 this),
       base::Bind(&NetworkingPrivateGetPropertiesFunction::GetPropertiesFailed,
                  this));
   return true;
 }
 
 void NetworkingPrivateGetPropertiesFunction::GetPropertiesSuccess(
     const std::string& service_path,
     const base::DictionaryValue& dictionary) {
   base::DictionaryValue* network_properties = dictionary.DeepCopy();
   network_properties->SetStringWithoutPathExpansion(onc::network_config::kGUID,
                                                     service_path);
   SetResult(network_properties);
   SendResponse(true);
 }
 
 void NetworkingPrivateGetPropertiesFunction::GetPropertiesFailed(
     const std::string& error_name,
     scoped_ptr<base::DictionaryValue> error_data) {
   error_ = error_name;
   SendResponse(false);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
+// NetworkingPrivateGetManagedPropertiesFunction
+
+NetworkingPrivateGetManagedPropertiesFunction::
+  ~NetworkingPrivateGetManagedPropertiesFunction() {
+}
+
+bool NetworkingPrivateGetManagedPropertiesFunction::RunImpl() {
+  scoped_ptr<api::GetManagedProperties::Params> params =
+      api::GetManagedProperties::Params::Create(*args_);
+  EXTENSION_FUNCTION_VALIDATE(params);
+  // The |network_guid| parameter is storing the service path.
+  std::string service_path = params->network_guid;
+
+  ManagedNetworkConfigurationHandler::Get()->GetManagedProperties(
+      service_path,
+      base::Bind(&NetworkingPrivateGetManagedPropertiesFunction::Success,
+                 this),
+      base::Bind(&NetworkingPrivateGetManagedPropertiesFunction::Failure,
+                 this));
+  return true;
+}
+
+void NetworkingPrivateGetManagedPropertiesFunction::Success(
+    const std::string& service_path,
+    const base::DictionaryValue& dictionary) {
+  base::DictionaryValue* network_properties = dictionary.DeepCopy();
+  network_properties->SetStringWithoutPathExpansion(onc::network_config::kGUID,
+                                                    service_path);
+  SetResult(network_properties);
+  SendResponse(true);
+}
+
+void NetworkingPrivateGetManagedPropertiesFunction::Failure(
+    const std::string& error_name,
+    scoped_ptr<base::DictionaryValue> error_data) {
+  error_ = error_name;
+  SendResponse(false);
+}
+
+////////////////////////////////////////////////////////////////////////////////
 // NetworkingPrivateGetStateFunction
 
 NetworkingPrivateGetStateFunction::
   ~NetworkingPrivateGetStateFunction() {
 }
 
 bool NetworkingPrivateGetStateFunction::RunImpl() {
   scoped_ptr<api::GetState::Params> params =
       api::GetState::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
@@ skipping 26 matching lines @@
 }
 
 bool NetworkingPrivateSetPropertiesFunction::RunImpl() {
   scoped_ptr<api::SetProperties::Params> params =
       api::SetProperties::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
 
   scoped_ptr<base::DictionaryValue> properties_dict(
       params->properties.ToValue());
 
+  // The |network_guid| parameter is storing the service path.

[pastarmovj, 2013/04/11 14:46:29]

Is there any other reason to create a temp here other than documenting the code
(which could be done inplace as well below)?

This comment applies for NetworkingPrivateGetManagedPropertiesFunction::RunImpl
as well.

[pneubeck (no reviews), 2013/04/15 12:16:24]

No other reason. If just found it harder to miss if it's a separate variable.

+  std::string service_path = params->network_guid;
+
   ManagedNetworkConfigurationHandler::Get()->SetProperties(
-      params->network_guid,
+      service_path,
       *properties_dict,
       base::Bind(&NetworkingPrivateSetPropertiesFunction::ResultCallback,
                  this),
       base::Bind(&NetworkingPrivateSetPropertiesFunction::ErrorCallback,
                  this));
   return true;
 }
 
 void NetworkingPrivateSetPropertiesFunction::ErrorCallback(
     const std::string& error_name,
@@ skipping 237 matching lines @@
     const std::string& result) {
   results_ = api::VerifyAndEncryptData::Results::Create(result);
   SendResponse(true);
 }
 
 void NetworkingPrivateVerifyAndEncryptDataFunction::ErrorCallback(
     const std::string& error_name, const std::string& error) {
   error_ = error_name;
   SendResponse(false);
 }