Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2628)

Unified Diff: base/trace_event/process_memory_maps_dump_provider.cc

Issue 1267573004: [tracing] Prevent memory maps dump for light dump requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@light_dumps
Patch Set: Typo. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/process_memory_maps_dump_provider.cc
diff --git a/base/trace_event/process_memory_maps_dump_provider.cc b/base/trace_event/process_memory_maps_dump_provider.cc
index 9c1bfcab8eccb91755707db140d6c534e9d8379b..750ca1119a4aa77aeea82b2cddb74d05127bb679 100644
--- a/base/trace_event/process_memory_maps_dump_provider.cc
+++ b/base/trace_event/process_memory_maps_dump_provider.cc
@@ -167,8 +167,9 @@ ProcessMemoryMapsDumpProvider::~ProcessMemoryMapsDumpProvider() {
// the current process.
bool ProcessMemoryMapsDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,
ProcessMemoryDump* pmd) {
- // TODO(ssid): Use MemoryDumpArgs to create light dumps when requested
- // (crbug.com/499731).
+ // Snapshot of memory maps is not taken for light dump requests.
+ if (args.level_of_detail == MemoryDumpArgs::LEVEL_OF_DETAIL_LOW)
+ return true;
uint32 res = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698