Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 1267513002: Revert of device/bluetooth/OWNERS: Add set noparent. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of device/bluetooth/OWNERS: Add set noparent. (patchset #1 id:1 of https://codereview.chromium.org/255473002/) Reason for revert: `set noparent` is generally an anti-pattern; if it's necessary there are usually bigger issues that need to be fixed. Sounds like that has happened for device/ and people are fine without noparent here, so reverting this. Original issue's description: > device/bluetooth/OWNERS: Add set noparent. > > BUG=none > R=keybuk@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265784 TBR=keybuk@chromium.org,armansito@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/29fdfd0b26a59be0349fa30849cd9721896843f5 Cr-Commit-Position: refs/heads/master@{#345068}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M device/bluetooth/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Nico
Created Revert of device/bluetooth/OWNERS: Add set noparent.
5 years, 4 months ago (2015-07-29 16:22:54 UTC) #1
armansito
lgtm
5 years, 4 months ago (2015-07-29 16:25:46 UTC) #2
tandrii(chromium)
I am not sure if you still intend to commit this, but if so, if'd ...
5 years, 3 months ago (2015-08-24 14:59:22 UTC) #4
tandrii(chromium)
sorry, my instructions for getting out of this were wrong. tl;dr if you want to ...
5 years, 3 months ago (2015-08-24 15:16:13 UTC) #6
Nico
On 2015/08/24 15:16:13, tandrii(chromium) wrote: > sorry, my instructions for getting out of this were ...
5 years, 3 months ago (2015-08-24 15:20:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267513002/40001
5 years, 3 months ago (2015-08-24 15:20:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-08-24 15:21:15 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-24 15:21:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29fdfd0b26a59be0349fa30849cd9721896843f5
Cr-Commit-Position: refs/heads/master@{#345068}

Powered by Google App Engine
This is Rietveld 408576698