Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1267493006: Remove JSFunctionResultCache. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove JSFunctionResultCache. There is only one use case for it: String.prototype.search converts a string argument into a RegExp. The cache is used to avoid repeating that conversion. However, this does not make the added complexity worthwhile. Committed: https://crrev.com/4a2e4420b8af50ca066905d99e7d7938c9105258 Cr-Commit-Position: refs/heads/master@{#29985}

Patch Set 1 #

Patch Set 2 : fixed tests #

Patch Set 3 : fix more #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -924 lines) Patch
M include/v8.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 3 chunks +0 lines, -46 lines 0 comments Download
M src/contexts.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 1 chunk +0 lines, -57 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +0 lines, -24 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.h View 1 2 3 3 chunks +0 lines, -37 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M src/objects-inl.h View 1 2 3 3 chunks +0 lines, -59 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +0 lines, -105 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/cctest.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +2 lines, -112 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Yang
5 years, 4 months ago (2015-08-03 08:39:24 UTC) #2
Michael Starzinger
LGTM if the performance impact is negligible. If this ends up regressing something heavily, then ...
5 years, 4 months ago (2015-08-03 10:29:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267493006/1
5 years, 4 months ago (2015-08-03 10:34:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8325)
5 years, 4 months ago (2015-08-03 10:45:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267493006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267493006/20001
5 years, 4 months ago (2015-08-03 12:56:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2919)
5 years, 4 months ago (2015-08-03 13:06:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267493006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267493006/40001
5 years, 4 months ago (2015-08-03 13:52:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/6687) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-08-03 13:53:09 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267493006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267493006/60001
5 years, 4 months ago (2015-08-03 14:03:26 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4642)
5 years, 4 months ago (2015-08-03 14:06:51 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267493006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267493006/60001
5 years, 4 months ago (2015-08-03 18:12:01 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-03 18:14:02 UTC) #25
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:14:28 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4a2e4420b8af50ca066905d99e7d7938c9105258
Cr-Commit-Position: refs/heads/master@{#29985}

Powered by Google App Engine
This is Rietveld 408576698