Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 1267493005: Use bundled freetype for tests. (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use bundled freetype for the pdfium_test binary. But use platform freetype for library itself according to the rules for the platform. This should greatly reduce per-platform diffs in the corpus tests, but requires that the corpus be rolled at the same time. When this rolls into chromium, its src/BUILD.gn will need to be updated to say third_party:fx_freetype instead of third_party:freetype. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/22955d987b30056d787d5eeb1a8ac8a1277bf5e0

Patch Set 1 #

Patch Set 2 : Typo #

Total comments: 1

Patch Set 3 : Remove -lfreetype from pdfium_test link. #

Patch Set 4 : libs not present in GN side #

Patch Set 5 : comment #

Patch Set 6 : DEPS picks up corresponding expected results. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download
M samples/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M samples/samples.gyp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/third_party.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
jam@, for review. The idea is that we build freetype, but give it a different ...
5 years, 4 months ago (2015-07-30 15:51:24 UTC) #3
jam
lgtm https://codereview.chromium.org/1267493005/diff/20001/samples/samples.gyp File samples/samples.gyp (right): https://codereview.chromium.org/1267493005/diff/20001/samples/samples.gyp#newcode27 samples/samples.gyp:27: # of results across platforms. please copy this ...
5 years, 4 months ago (2015-07-30 17:18:03 UTC) #4
Tom Sepez
On 2015/07/30 17:18:03, jam wrote: > lgtm > > https://codereview.chromium.org/1267493005/diff/20001/samples/samples.gyp > File samples/samples.gyp (right): > ...
5 years, 4 months ago (2015-07-30 17:21:48 UTC) #5
Tom Sepez
5 years, 4 months ago (2015-07-30 17:29:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
22955d987b30056d787d5eeb1a8ac8a1277bf5e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698