Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: base/message_loop/message_pump_win.cc

Issue 1267483003: Combine the WM_CHAR with WM_KEY* for key event flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/input_method_win.h » ('j') | ui/base/ime/input_method_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_win.cc
diff --git a/base/message_loop/message_pump_win.cc b/base/message_loop/message_pump_win.cc
index 10e308aa9dc3406ad5d1f02c5edca8e6a83573c9..0a102bc57a11ea34b91382b4d2de72fe740d65bc 100644
--- a/base/message_loop/message_pump_win.cc
+++ b/base/message_loop/message_pump_win.cc
@@ -400,10 +400,12 @@ bool MessagePumpForUI::ProcessMessageHelper(const MSG& msg) {
}
if (action & MessagePumpDispatcher::POST_DISPATCH_QUIT_LOOP)
state_->should_quit = true;
- if (action & MessagePumpDispatcher::POST_DISPATCH_PERFORM_DEFAULT) {
- TranslateMessage(&msg);
+ // Don't call TranslateMessage() here but call TranslateMessage() in
+ // InputMethodWin, so that the WM_KEYDOWN & WM_CHAR can be combined for key
James Su 2015/08/04 17:06:44 WM_KEYDOWN/WM_KEYUP
Shu Chen 2015/08/05 01:36:45 Done.
+ // event flow. The combination as single key event is required for Chrome
+ // IMEs, which can do IME related actions based on the single key event.
+ if (action & MessagePumpDispatcher::POST_DISPATCH_PERFORM_DEFAULT)
DispatchMessage(&msg);
- }
return true;
}
« no previous file with comments | « no previous file | ui/base/ime/input_method_win.h » ('j') | ui/base/ime/input_method_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698