Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Unified Diff: win8/metro_driver/chrome_app_view_ash.cc

Issue 1267483003: Combine the WM_CHAR with WM_KEY* for key event flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed yukawa@'s comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/metro_driver/chrome_app_view_ash.cc
diff --git a/win8/metro_driver/chrome_app_view_ash.cc b/win8/metro_driver/chrome_app_view_ash.cc
index 776f23ee99b1170ebd72ca58eb0af6369f7654ac..eaba5fb23a5803a5fcdc17593c4058a271372331 100644
--- a/win8/metro_driver/chrome_app_view_ash.cc
+++ b/win8/metro_driver/chrome_app_view_ash.cc
@@ -1267,10 +1267,14 @@ HRESULT ChromeAppViewAsh::OnCharacterReceived(
if (FAILED(hr))
return hr;
- ui_channel_->Send(new MetroViewerHostMsg_Character(char_code,
- status.RepeatCount,
- status.ScanCode,
- GetKeyboardEventFlags()));
+ if (status.WasKeyDown) {
+ ui_channel_->Send(
+ new MetroViewerHostMsg_CharacterForNextKeyEvent(char_code);
+ } else {
+ ui_channel_->Send(new MetroViewerHostMsg_Character(
+ char_code, status.RepeatCount, status.ScanCode,
+ GetKeyboardEventFlags()));
+ }
return S_OK;
}

Powered by Google App Engine
This is Rietveld 408576698