base/base_switches.h - Issue 1267483003: Combine the WM_CHAR with WM_KEY* for key event flow.

Side by Side Diff: base/base_switches.h

Issue 1267483003: Combine the WM_CHAR with WM_KEY* for key event flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed yukawa@'s comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines all the "base" command-line switches.	5 // Defines all the "base" command-line switches.

6	6

7 #ifndef BASE_BASE_SWITCHES_H_	7 #ifndef BASE_BASE_SWITCHES_H_

8 #define BASE_BASE_SWITCHES_H_	8 #define BASE_BASE_SWITCHES_H_

9	9

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 10 matching lines...) Expand all Loading...
21 extern const char kProfilerTimingDisabledValue[];	21 extern const char kProfilerTimingDisabledValue[];

22 extern const char kTestChildProcess[];	22 extern const char kTestChildProcess[];

23 extern const char kTraceToConsole[];	23 extern const char kTraceToConsole[];

24 extern const char kTraceToFile[];	24 extern const char kTraceToFile[];

25 extern const char kTraceToFileName[];	25 extern const char kTraceToFileName[];

26 extern const char kV[];	26 extern const char kV[];

27 extern const char kVModule[];	27 extern const char kVModule[];

28 extern const char kWaitForDebugger[];	28 extern const char kWaitForDebugger[];

29	29

30 #if defined(OS_WIN)	30 #if defined(OS_WIN)

	31 extern const char kDisableMergeKeyCharEvents[];
	Nico 2015/08/19 21:29:31 These flags aren't read from base/ so they shouldn These flags aren't read from base/ so they shouldn't be defined in base_switches Shu Chen 2015/08/20 00:54:27 Is there a common switches header file that can be Show quoted text On 2015/08/19 21:29:31, Nico (on vacation Thu Aug 20) wrote: > These flags aren't read from base/ so they shouldn't be defined in base_switches Is there a common switches header file that can be included from ui/base? Nico 2015/08/20 02:51:57 https://code.google.com/p/chromium/codesearch#sear Show quoted text On 2015/08/20 00:54:27, Shu Chen wrote: > On 2015/08/19 21:29:31, Nico (on vacation Thu Aug 20) wrote: > > These flags aren't read from base/ so they shouldn't be defined in > base_switches > > Is there a common switches header file that can be included from ui/base? https://code.google.com/p/chromium/codesearch#search/&q=file:ui/base%20switch... maybe? Shu Chen 2015/08/20 02:59:59 Done. Thank you! Show quoted text On 2015/08/20 02:51:57, Nico (on vacation Thu Aug 20) wrote: > On 2015/08/20 00:54:27, Shu Chen wrote: > > On 2015/08/19 21:29:31, Nico (on vacation Thu Aug 20) wrote: > > > These flags aren't read from base/ so they shouldn't be defined in > > base_switches > > > > Is there a common switches header file that can be included from ui/base? > > https://code.google.com/p/chromium/codesearch#search/&q=file:ui/base%20switch... > maybe? Done. Thank you!
31 extern const char kDisableUsbKeyboardDetect[];	32 extern const char kDisableUsbKeyboardDetect[];

	33 extern const char kEnableMergeKeyCharEvents[];

32 #endif	34 #endif

33	35

34 #if defined(OS_POSIX)	36 #if defined(OS_POSIX)

35 extern const char kEnableCrashReporterForTesting[];	37 extern const char kEnableCrashReporterForTesting[];

36 #endif	38 #endif

37	39

38 } // namespace switches	40 } // namespace switches

39	41

40 #endif // BASE_BASE_SWITCHES_H_	42 #endif // BASE_BASE_SWITCHES_H_

OLD	NEW

« no previous file with comments | « no previous file | base/base_switches.cc » ('j') | no next file with comments »