Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1267483002: Put the `mojo_test` test list format in the command line description. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Put the `mojo_test` test list format in the command line description. This requires setting formatter_class=argparse.RawDescriptionHelpFormatter so that the line breaks are preserved in the output. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2ecd755884624b8f17a4403bfa01c7bd6f2164e7

Patch Set 1 #

Patch Set 2 : Move the imports to their place. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M mojo/devtools/common/mojo_test View 1 2 chunks +24 lines, -22 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ppi
Hi Ben, ptal.
5 years, 4 months ago (2015-07-29 13:18:41 UTC) #1
qsr
https://codereview.chromium.org/1267483002/diff/20001/mojo/devtools/common/mojo_test File mojo/devtools/common/mojo_test (left): https://codereview.chromium.org/1267483002/diff/20001/mojo/devtools/common/mojo_test#oldcode31 mojo/devtools/common/mojo_test:31: TODO(vtl|msw): Add a way of specifying data dependencies. Where ...
5 years, 4 months ago (2015-07-29 13:37:57 UTC) #2
ppi
https://codereview.chromium.org/1267483002/diff/20001/mojo/devtools/common/mojo_test File mojo/devtools/common/mojo_test (right): https://codereview.chromium.org/1267483002/diff/20001/mojo/devtools/common/mojo_test#newcode8 mojo/devtools/common/mojo_test:8: TODO(vtl|msw): Add a way of specifying data dependencies. here.
5 years, 4 months ago (2015-07-29 13:38:43 UTC) #3
qsr
lgtm
5 years, 4 months ago (2015-07-29 14:18:12 UTC) #4
ppi
5 years, 4 months ago (2015-07-29 14:20:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ecd755884624b8f17a4403bfa01c7bd6f2164e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698