chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc - Issue 12674028: Report text output and exit code for command-line operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

Issue 12674028: Report text output and exit code for command-line operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Line endings. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/startup_browser_creator.cc ('K') | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/common/chrome_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

index bf3a31ffe6e1b5b2d933852fb4767e17a6e843d1..1ee6ae124fc8a8488cf35ea7a8ed4c9e5824d747 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc

@@ -8,6 +8,7 @@

#include "base/files/file_path.h"

#include "base/message_loop.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/operation_output.h"

#include "chrome/browser/prefs/session_startup_pref.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/sessions/session_restore.h"

@@ -60,7 +61,6 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, LastUsedProfileActivated) {

// Do a simple non-process-startup browser launch.

CommandLine dummy(CommandLine::NO_PROGRAM);

- int return_code;

StartupBrowserCreator browser_creator;

std::vector<Profile*> last_opened_profiles;

last_opened_profiles.push_back(profile_1);

@@ -68,7 +68,7 @@ IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, LastUsedProfileActivated) {

last_opened_profiles.push_back(profile_3);

last_opened_profiles.push_back(profile_4);

browser_creator.Start(dummy, profile_manager->user_data_dir(), profile_2,

- last_opened_profiles, &return_code);

+ last_opened_profiles, scoped_ptr<OperationOutput>());

while (!browser_creator.ActivatedProfile())

MessageLoop::current()->RunUntilIdle();