chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc - Issue 12674028: Report text output and exit code for command-line operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 12674028: Report text output and exit code for command-line operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Forgotten review responses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/operation_output_win.cc ('k') | chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

index b18645817278f36a93073554e426050ddd920783..b27ff5478daaef32c0443ff3608156c6d4e5f05e 100644

--- a/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

+++ b/chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

@@ -8,6 +8,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/message_loop.h"

#include "base/prefs/testing_pref_service.h"

+#include "chrome/browser/operation_output.h"

#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service.h"

#include "chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h"

#include "chrome/browser/service/service_process_control.h"

@@ -188,11 +189,11 @@ class CloudPrintProxyPolicyTest : public ::testing::Test {

}

bool LaunchBrowser(const CommandLine& command_line, Profile* profile) {

- int return_code = 0;

StartupBrowserCreator browser_creator;

return StartupBrowserCreator::ProcessCmdLineImpl(

command_line, base::FilePath(), false, profile,

- StartupBrowserCreator::Profiles(), &return_code, &browser_creator);

+ StartupBrowserCreator::Profiles(), &browser_creator,

+ scoped_ptr<OperationOutput>());

}

protected: