Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: apps/apps.gypi

Issue 12674028: Report text output and exit code for command-line operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgotten review responses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/app_host/test_operation.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/apps.gypi
diff --git a/apps/apps.gypi b/apps/apps.gypi
index 61f42e91aea6bd3e641714c4b09698cdf260d6be..0968a4df1c58eacd61ca9fab1140cfc37d8f111a 100644
--- a/apps/apps.gypi
+++ b/apps/apps.gypi
@@ -65,8 +65,8 @@
{
'targets': [
{
- 'target_name': 'app_host',
- 'type': 'executable',
+ 'target_name': 'app_host_lib',
+ 'type': 'static_library',
'include_dirs': [
'..',
],
@@ -77,18 +77,35 @@
},
'dependencies': [
'../base/base.gyp:base',
- '../chrome/chrome.gyp:chrome_version_resources',
'../chrome/chrome.gyp:launcher_support',
+ '../chrome/common_constants.gyp:common_constants',
'../google_update/google_update.gyp:google_update',
],
'sources': [
- 'app_host/app_host.rc',
- 'app_host/app_host_main.cc',
- 'app_host/app_host_resource.h',
'app_host/binaries_installer.cc',
'app_host/binaries_installer.h',
+ 'app_host/operation_launcher.cc',
+ 'app_host/operation_launcher.h',
'app_host/update.cc',
'app_host/update.h',
+ ],
+ },
+ {
+ 'target_name': 'app_host',
+ 'type': 'executable',
+ 'include_dirs': [
+ '..',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../chrome/chrome.gyp:chrome_version_resources',
+ '../chrome/chrome.gyp:launcher_support',
+ 'app_host_lib',
+ ],
+ 'sources': [
+ 'app_host/app_host.rc',
+ 'app_host/app_host_main.cc',
+ 'app_host/app_host_resource.h',
'<(SHARED_INTERMEDIATE_DIR)/chrome_version/app_host_exe_version.rc',
],
'msvs_settings': {
@@ -97,6 +114,38 @@
},
},
},
+ {
+ 'target_name': 'test_operation',
+ 'type': 'executable',
+ 'include_dirs': [
+ '..',
+ ],
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../chrome/chrome.gyp:browser',
+ '../chrome/common_constants.gyp:common_constants',
+ ],
+ 'sources': [
+ 'app_host/test_operation.cc',
+ ],
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
+ },
+ },
+ },
+ {
+ 'target_name': 'app_host_unittests',
+ 'type': '<(gtest_target_type)',
+ 'sources': [
+ ],
+ 'dependencies': [
+ '../base/base.gyp:run_all_unittests',
+ '../testing/gtest.gyp:gtest',
+ ]
+ }
+
+
],
},
], # 'OS=="win"'
« no previous file with comments | « apps/app_host/test_operation.cc ('k') | chrome/browser/chrome_browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698