Report text output and exit code for command-line operations.

apps/app_host/app_host_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include "apps/app_host/binaries_installer.h"
+#include "apps/app_host/operation_launcher.h"
 #include "apps/app_host/update.h"
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
-#include "base/process_util.h"
 #include "chrome/installer/launcher_support/chrome_launcher_support.h"
 
+

[gab, 2013/03/28 03:06:06]

nit: Remove extra empty line.

 int APIENTRY wWinMain(HINSTANCE, HINSTANCE, wchar_t*, int) {
   base::AtExitManager exit_manager;
 
   // Initialize the commandline singleton from the environment.
   CommandLine::Init(0, NULL);
 
   base::FilePath chrome_exe(chrome_launcher_support::GetAnyChromePath());
   if (chrome_exe.empty()) {
     LOG(INFO) << "No Chrome executable could be found. Let's install it.";
     HRESULT hr = app_host::InstallBinaries();
     if (FAILED(hr)) {
       LOG(ERROR) << "Failed to install the Chrome Binaries. Error: " << hr;
       return 1;
     } else {
       chrome_exe = chrome_launcher_support::GetAnyChromePath();
       if (chrome_exe.empty()) {
         LOG(ERROR) << "Failed to find the Chrome Binaries despite a "
                    << "'successful' installation.";
         return 1;
       }
     }
   }
 
   CommandLine chrome_exe_command_line(chrome_exe);
   chrome_exe_command_line.AppendArguments(
       *CommandLine::ForCurrentProcess(), false);
+
   // Launch Chrome before checking for update, for faster user experience.

[robertshield, 2013/03/28 02:38:03]

grammar nit: for -> for a 

-  bool launch_result = base::LaunchProcess(chrome_exe_command_line,
-                                           base::LaunchOptions(), NULL);
-  if (launch_result)
-    LOG(INFO) << "Delegated to Chrome executable at " << chrome_exe.value();
-  else
-    LOG(INFO) << "Failed to launch Chrome executable at " << chrome_exe.value();
+  DWORD exit_code = 0;
+  if (!app_host::LaunchOperation(chrome_exe_command_line,
+                                 ::GetStdHandle(STD_OUTPUT_HANDLE),
+                                 &exit_code)) {
+    LOG(ERROR) << "Failed to delegate to Chrome.";

[gab, 2013/03/28 03:06:06]

Does this need to make it in Release builds or is a NOTREACHED() sufficient
here?

[erikwright (departed), 2013/04/18 17:43:04]

This is not a NOTREACHED scenario. Things out of our control could cause this to
happen.

I think the log message is useful in that case.

+    return 1;

[gab, 2013/03/28 03:06:06]

This should be a constant return code, no?

+  }
 
   app_host::EnsureAppHostUpToDate();
 
-  return !launch_result;
+  return exit_code;
 }