Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/process_singleton_startup_lock.cc

Issue 12674028: Report text output and exit code for command-line operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgotten review responses. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/process_singleton_startup_lock.h" 5 #include "chrome/browser/process_singleton_startup_lock.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/operation_output.h"
9 10
10 ProcessSingletonStartupLock::ProcessSingletonStartupLock( 11 ProcessSingletonStartupLock::ProcessSingletonStartupLock(
11 const ProcessSingleton::NotificationCallback& original_callback) 12 const OperationCallback& operation_callback)
12 : locked_(true), 13 : locked_(true),
13 original_callback_(original_callback) {} 14 operation_callback_(operation_callback) {}
14 15
15 ProcessSingletonStartupLock::~ProcessSingletonStartupLock() {} 16 ProcessSingletonStartupLock::~ProcessSingletonStartupLock() {
17 for (std::vector<DelayedStartupMessage>::const_iterator it =
18 saved_startup_messages_.begin();
19 it != saved_startup_messages_.end(); ++it) {
20 if (it->operation_output_)
21 delete it->operation_output_;
22 }
23 }
16 24
17 ProcessSingleton::NotificationCallback 25 ProcessSingleton::NotificationCallback
18 ProcessSingletonStartupLock::AsNotificationCallback() { 26 ProcessSingletonStartupLock::AsNotificationCallback() {
19 return base::Bind(&ProcessSingletonStartupLock::NotificationCallbackImpl, 27 return base::Bind(&ProcessSingletonStartupLock::NotificationCallbackImpl,
20 base::Unretained(this)); 28 base::Unretained(this));
21 } 29 }
22 30
23 void ProcessSingletonStartupLock::Unlock() { 31 void ProcessSingletonStartupLock::Unlock() {
24 DCHECK(CalledOnValidThread()); 32 DCHECK(CalledOnValidThread());
25 locked_ = false; 33 locked_ = false;
26 34
27 // Replay the command lines of the messages which were received while the 35 // Replay the command lines of the messages which were received while the
28 // ProcessSingleton was locked. Only replay each message once. 36 // ProcessSingleton was locked. Only replay each message once.
29 std::set<DelayedStartupMessage> replayed_messages; 37 std::set<std::pair<CommandLine::StringVector,
38 base::FilePath> > replayed_messages;
30 for (std::vector<DelayedStartupMessage>::const_iterator it = 39 for (std::vector<DelayedStartupMessage>::const_iterator it =
31 saved_startup_messages_.begin(); 40 saved_startup_messages_.begin();
32 it != saved_startup_messages_.end(); ++it) { 41 it != saved_startup_messages_.end(); ++it) {
33 if (replayed_messages.find(*it) != replayed_messages.end()) 42 scoped_ptr<OperationOutput> operation_output(it->operation_output_);
43 std::pair<CommandLine::StringVector, base::FilePath> pair(
44 it->argv_, it->current_directory_);
45 if (replayed_messages.find(pair) != replayed_messages.end())
34 continue; 46 continue;
35 original_callback_.Run(CommandLine(it->first), it->second); 47 operation_callback_.Run(CommandLine(it->argv_),
36 replayed_messages.insert(*it); 48 it->current_directory_,
49 operation_output.Pass());
50 replayed_messages.insert(pair);
37 } 51 }
38 saved_startup_messages_.clear(); 52 saved_startup_messages_.clear();
39 } 53 }
40 54
41 bool ProcessSingletonStartupLock::NotificationCallbackImpl( 55 bool ProcessSingletonStartupLock::NotificationCallbackImpl(
42 const CommandLine& command_line, 56 const CommandLine& command_line,
43 const base::FilePath& current_directory) { 57 const base::FilePath& current_directory) {
58 scoped_ptr<OperationOutput> operation_output =
59 OperationOutput::Create(command_line);
44 if (locked_) { 60 if (locked_) {
45 // If locked, it means we are not ready to process this message because 61 // If locked, it means we are not ready to process this message because
46 // we are probably in a first run critical phase. 62 // we are probably in a first run critical phase.
47 saved_startup_messages_.push_back( 63 saved_startup_messages_.push_back(
48 std::make_pair(command_line.argv(), current_directory)); 64 DelayedStartupMessage(command_line.argv(),
65 current_directory,
66 operation_output.release()));
49 return true; 67 return true;
50 } else { 68 } else {
51 return original_callback_.Run(command_line, current_directory); 69 return operation_callback_.Run(command_line,
70 current_directory,
71 operation_output.Pass());
52 } 72 }
53 } 73 }
74
75 ProcessSingletonStartupLock::DelayedStartupMessage::DelayedStartupMessage(
76 const CommandLine::StringVector& argv,
77 const base::FilePath& current_directory,
78 OperationOutput* operation_output)
79 : argv_(argv),
80 current_directory_(current_directory),
81 operation_output_(operation_output) {
82 }
83
84 ProcessSingletonStartupLock::DelayedStartupMessage::~DelayedStartupMessage() {}
OLDNEW
« no previous file with comments | « chrome/browser/process_singleton_startup_lock.h ('k') | chrome/browser/ui/startup/startup_browser_creator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698