Fix playing video files with hash in the filename in Files.app.

chrome/browser/chromeos/extensions/file_manager_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "chrome/browser/chromeos/extensions/file_manager_util.h"
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/json/json_reader.h"
@@ skipping 599 matching lines @@
                                 GURL* url) {
   GURL origin_url = Extension::GetBaseURLFromExtensionId(extension_id);
   base::FilePath virtual_path;
   if (!ConvertFileToRelativeFileSystemPath(profile, extension_id,
            full_file_path, &virtual_path)) {
     return false;
   }
 
   GURL base_url = fileapi::GetFileSystemRootURI(origin_url,
       fileapi::kFileSystemTypeExternal);
-  *url = GURL(base_url.spec() + virtual_path.value());
+  *url = GURL(base_url.spec() +
+              net::EscapeUrlEncodedData(virtual_path.value(), false));

[hashimoto, 2013/03/08 07:12:47]

boolean arguments are hard to read. (see "nullptr/NULL, true/false, 1, 2, 3..."
section of
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Implem...)

Could you clarify what "false" here mean?

[mtomasz, 2013/03/11 03:54:29]

Added comments. Done.

   return true;
 }
 
 bool ConvertFileToRelativeFileSystemPath(
     Profile* profile,
     const std::string& extension_id,
     const base::FilePath& full_file_path,
     base::FilePath* virtual_path) {
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
@@ skipping 336 matching lines @@
   for (google_apis::OperationProgressStatusList::const_iterator iter =
            list.begin();
        iter != list.end(); ++iter) {
     result_list->Append(
         ProgessStatusToDictionaryValue(profile, extension_id, *iter));
   }
   return result_list.release();
 }
 
 }  // namespace file_manager_util