Port morphology to SkOpts.

src/core/SkOpts.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkOnce.h"
 #include "SkOpts.h"
 
 #define SK_OPTS_NS portable
 #include "SkBlurImageFilter_opts.h"
 #include "SkFloatingPoint_opts.h"
+#include "SkMorphologyImageFilter_opts.h"
 #include "SkUtils_opts.h"
 #include "SkXfermode_opts.h"
 
 #if defined(SK_CPU_X86)
     #if defined(SK_BUILD_FOR_WIN32)
         #include <intrin.h>
         static void cpuid(uint32_t abcd[4]) { __cpuid((int*)abcd, 1); }
     #else
         #include <cpuid.h>
         static void cpuid(uint32_t abcd[4]) { __get_cpuid(1, abcd+0, abcd+1, abcd+2, abcd+3); }
     #endif
 #elif !defined(SK_ARM_HAS_NEON) && defined(SK_CPU_ARM32) && defined(SK_BUILD_FOR_ANDROID)
     #include <cpu-features.h>
 #endif
 
 namespace SkOpts {
     // Define default function pointer values here...
     // If our global compile options are set high enough, these 'portable' defaults might
     // even be CPU-specialized, e.g. a typical x86-64 machine might start with SSE2 defaults.
     // They'll still get a chance to be replaced with even better ones, e.g. using SSE4.1.
     decltype(rsqrt)                     rsqrt = portable::rsqrt;
     decltype(memset16)               memset16 = portable::memset16;
     decltype(memset32)               memset32 = portable::memset32;
     decltype(create_xfermode) create_xfermode = SkCreate4pxXfermode;
 
-    static const auto x = portable::kX, y = portable::kY;
-    decltype(box_blur_xx) box_blur_xx = portable::box_blur<x,x>;
-    decltype(box_blur_xy) box_blur_xy = portable::box_blur<x,y>;
-    decltype(box_blur_yx) box_blur_yx = portable::box_blur<y,x>;
+    decltype(box_blur_xx) box_blur_xx = portable::box_blur_xx;

[djsollen, 2015/08/04 19:38:12]

why not

static const auto blur_x = portable::BlurDirection::kX;

and avoid having to declare those static functions.

[mtklein_C, 2015/08/04 19:41:48]

This is mostly a style / layering thing.  I noticed that the implementation
details of those box blurs (that they're a single function template) were
leaking out.  Same deal of course with the morphs.

+    decltype(box_blur_xy) box_blur_xy = portable::box_blur_xy;
+    decltype(box_blur_yx) box_blur_yx = portable::box_blur_yx;
+
+    decltype(dilate_x) dilate_x = portable::dilate_x;

[djsollen, 2015/08/04 19:38:12]

does decltype really help here?  It seems that Morph would be just fine since we
have a typedef.  Same for the box blurs.

[mtklein_C, 2015/08/04 19:41:48]

Either would be fine.  On the other hand, decltype(x) x = ... works uniformly
for all these function pointers.

+    decltype(dilate_y) dilate_y = portable::dilate_y;
+    decltype( erode_x)  erode_x = portable::erode_x;
+    decltype( erode_y)  erode_y = portable::erode_y;
 
     // Each Init_foo() is defined in src/opts/SkOpts_foo.cpp.
     void Init_sse2();
     void Init_ssse3();
     void Init_sse41();
     void Init_neon();
     //TODO: _dsp2, _armv7, _armv8, _x86, _x86_64, _sse42, _avx, avx2, ... ?
 
     static void init() {
         // TODO: Chrome's not linking _sse* opts on iOS simulator builds.  Bug or feature?
@@ skipping 12 matching lines @@
 
     SK_DECLARE_STATIC_ONCE(gInitOnce);
     void Init() { SkOnce(&gInitOnce, init); }
 
 #if SK_ALLOW_STATIC_GLOBAL_INITIALIZERS
     static struct AutoInit {
         AutoInit() { Init(); }
     } gAutoInit;
 #endif
 }