Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1267313002: Retire ShortCircuitConsString. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Retire ShortCircuitConsString. BUG= Committed: https://crrev.com/53be2063cc0abb0615e8f544cf202b86d4eacca9 Cr-Commit-Position: refs/heads/master@{#30015}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M src/heap/mark-compact.cc View 1 3 chunks +2 lines, -37 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
titzer
Bye bye love Bye bye happiness Hello loneliness I think I'm-a gonna cry-y Actually, no, ...
5 years, 4 months ago (2015-08-04 16:51:28 UTC) #2
Michael Starzinger
Instant LGTM. If had more than one LGTM to give, I would give two. :)
5 years, 4 months ago (2015-08-04 17:00:10 UTC) #4
Hannes Payer (out of office)
5 years, 4 months ago (2015-08-04 17:00:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267313002/1
5 years, 4 months ago (2015-08-04 17:03:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/7346) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 4 months ago (2015-08-04 17:04:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267313002/20001
5 years, 4 months ago (2015-08-04 18:49:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-04 19:19:25 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 19:20:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53be2063cc0abb0615e8f544cf202b86d4eacca9
Cr-Commit-Position: refs/heads/master@{#30015}

Powered by Google App Engine
This is Rietveld 408576698