pepper: Use the RenderThread's shared context as the parent context.

content/renderer/render_widget_fullscreen_pepper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget_fullscreen_pepper.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 433 matching lines @@
 }
 
 void RenderWidgetFullscreenPepper::DidChangeCursor(
     const WebKit::WebCursorInfo& cursor) {
   didChangeCursor(cursor);
 }
 
 webkit::ppapi::PluginDelegate::PlatformContext3D*
 RenderWidgetFullscreenPepper::CreateContext3D() {
 #ifdef ENABLE_GPU
-  return new PlatformContext3DImpl(this);
+  return new PlatformContext3DImpl;
 #else
   return NULL;
 #endif
 }
 
-void RenderWidgetFullscreenPepper::ReparentContext(
-    webkit::ppapi::PluginDelegate::PlatformContext3D* context) {
-  static_cast<PlatformContext3DImpl*>(context)->SetParentContext(this);
-}
-
 bool RenderWidgetFullscreenPepper::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(RenderWidgetFullscreenPepper, msg)
     IPC_MESSAGE_FORWARD(ViewMsg_LockMouse_ACK,
                         mouse_lock_dispatcher_.get(),
                         MouseLockDispatcher::OnLockMouseACK)
     IPC_MESSAGE_FORWARD(ViewMsg_MouseLockLost,
                         mouse_lock_dispatcher_.get(),
                         MouseLockDispatcher::OnMouseLockLost)
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ skipping 83 matching lines @@
 
 void RenderWidgetFullscreenPepper::CreateContext() {
   DCHECK(!context_);
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDisableFlashFullscreen3d))
     return;
   WebKit::WebGraphicsContext3D::Attributes attributes;
   attributes.depth = false;
   attributes.stencil = false;
   attributes.antialias = false;
-  attributes.shareResources = false;
+  attributes.shareResources = true;
   attributes.preferDiscreteGPU = true;
   context_ = WebGraphicsContext3DCommandBufferImpl::CreateViewContext(
       RenderThreadImpl::current(),
       surface_id(),
       NULL,
       attributes,
       true /* bind generates resources */,
       active_url_,
       CAUSE_FOR_GPU_LAUNCH_RENDERWIDGETFULLSCREENPEPPER_CREATECONTEXT);
   if (!context_)
@@ skipping 98 matching lines @@
                  kTexCoords,
                  GL_STATIC_DRAW);
   context_->vertexAttribPointer(0, 2,
                                 GL_FLOAT, GL_FALSE,
                                 0, static_cast<WGC3Dintptr>(NULL));
   context_->enableVertexAttribArray(0);
   return true;
 }
 
 bool RenderWidgetFullscreenPepper::CheckCompositing() {
+  if (webwidget_) {
+    if (context_ && context_->isContextLost()) {
+      DestroyContext(context_, program_, buffer_);
+      context_ = NULL;
+    }
+    if (!context_)
+      CreateContext();

[piman, 2013/03/08 04:43:16]

We should only create the context if the plugin has a context/texture. You don't
want to pay for a context for software.

I'd think you could do this below after you checked
webwidget_->isAcceleratedCompositingActive, provided that one doesn't check back
for this context (I don't think it needs to any more).

[danakj, 2013/03/08 18:13:34]

Done.

+  } else if (context_) {

[piman, 2013/03/08 04:43:16]

I don't really think you need this clause. The webwidget_ should always be there
except maybe at construction and destruction, but we will destroy the context in
the destructor.

However we do need to destroy the context if we switch from compositing to not.

[danakj, 2013/03/08 18:13:34]

Done.

+    DestroyContext(context_, program_, buffer_);
+    context_ = NULL;
+  }
+
   bool compositing =
       webwidget_ && webwidget_->isAcceleratedCompositingActive();
   if (compositing != is_accelerated_compositing_active_) {
     if (compositing)
       didActivateCompositor(-1);
     else
       didDeactivateCompositor();
   }
   return compositing;
 }
 
 void RenderWidgetFullscreenPepper::SwapBuffers() {
   DCHECK(context_);
   context_->prepareTexture();
 
   // The compositor isn't actually active in this path, but pretend it is for
   // scheduling purposes.
   didCommitAndDrawCompositorFrame();
 }
 
-WebGraphicsContext3DCommandBufferImpl*
-RenderWidgetFullscreenPepper::GetParentContextForPlatformContext3D() {
-  if (!context_) {
-    CreateContext();
-  }
-  if (!context_)
-    return NULL;
-  return context_;
-}
-
 }  // namespace content