Gracefully handle XMLDocumentParser being detached by mutation events.

Gracefully handle XMLDocumentParser being detached by mutation events.

Should a mutation event handler run while flushing out parser-buffered text,
we could end up in a detached state, something the implementation wasn't
prepared for.

Firm up exitText() usage, and rename it as updateLeafTextNode(). Also attempt
to make enterText() more descriptive as createLeafTextNodeIfNeeded().

R=haraken,tkent,kouhei
BUG=516290
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200026

[sof, 2015-08-04 11:38:36]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2015-08-04 11:38:36]

please take a look.

[haraken, 2015-08-04 12:37:58]

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
File Source/core/xml/parser/XMLDocumentParser.cpp (right):

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
Source/core/xml/parser/XMLDocumentParser.cpp:436: updateLeafTextNode();

Don't we need to early-return here?

[sof, 2015-08-04 12:42:35]

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
File Source/core/xml/parser/XMLDocumentParser.cpp (right):

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
Source/core/xml/parser/XMLDocumentParser.cpp:436: updateLeafTextNode();
On 2015/08/04 12:37:58, haraken wrote:
> 
> Don't we need to early-return here?

No, we could be in a Stopped state and need to bottom out instead. See ps#2
timeouts for what happens if you early-return.

[haraken, 2015-08-04 12:45:41]

On 2015/08/04 12:42:35, sof wrote:
>
https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
> File Source/core/xml/parser/XMLDocumentParser.cpp (right):
> 
>
https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
> Source/core/xml/parser/XMLDocumentParser.cpp:436: updateLeafTextNode();
> On 2015/08/04 12:37:58, haraken wrote:
> > 
> > Don't we need to early-return here?
> 
> No, we could be in a Stopped state and need to bottom out instead. See ps#2
> timeouts for what happens if you early-return.

Thanks, maybe worth having a comment. LGTM.

[haraken, 2015-08-04 12:47:33]

haraken@chromium.org changed reviewers:
+ kouhei@chromium.org

[haraken, 2015-08-04 12:47:34]

+kouhei

[sof, 2015-08-04 13:52:31]

Thanks; will leave this one alone overnight, lest anyone else wants to have a
look.

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
File Source/core/xml/parser/XMLDocumentParser.cpp (right):

https://codereview.chromium.org/1267283002/diff/40001/Source/core/xml/parser/...
Source/core/xml/parser/XMLDocumentParser.cpp:436: updateLeafTextNode();
On 2015/08/04 12:42:35, sof wrote:
> On 2015/08/04 12:37:58, haraken wrote:
> > 
> > Don't we need to early-return here?
> 
> No, we could be in a Stopped state and need to bottom out instead. See ps#2
> timeouts for what happens if you early-return.

Added clarifying comment.

[sof, 2015-08-04 13:55:36]

On 2015/08/04 13:52:31, sof wrote:
> Thanks; will leave this one alone overnight, lest anyone else wants to have a
> look.
>

"lest" is a poor choice of word, additional reviewing is most welcome! :)

[tkent, 2015-08-05 00:49:18]

Looks reasonable.  lgtm.

[kouhei (in TOK), 2015-08-05 03:48:48]

lgtm

[sof, 2015-08-05 05:11:43]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-08-05 05:11:44]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1267283002/#ps60001
(title: "add clarifying comment")

[commit-bot: I haz the power, 2015-08-05 05:11:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267283002/60001

[commit-bot: I haz the power, 2015-08-05 05:59:08]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200026