pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart - Issue 1267203002: add location to suggestions from local file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

Issue 1267203002: add location to suggestions from local file (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_suggestion_builder.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

index f8dcbdf2c20c2679d5d412fe4adf788f1f996c09..f3a9db439758e230a9f9b400c85c08ed3bc17fba 100644

--- a/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

@@ -137,7 +137,7 @@ class _FieldFormalSuggestionBuilder implements SuggestionBuilder {

if (fieldName != null && fieldName.length > 0) {

if (!referencedFields.contains(fieldName)) {

CompletionSuggestion suggestion =

- createFieldSuggestion(member, varDecl);

+ createFieldSuggestion(request.source, member, varDecl);

if (suggestion != null) {

request.addSuggestion(suggestion);

}