Hide requests in an extension from other extensions

chrome/browser/extensions/api/web_request/web_request_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 304 matching lines @@
   // Reload extension and wait for rules to be set up again. This should not
   // crash the browser.
   ExtensionTestMessageListener listener2("done", true);
   ExtensionTestMessageListener listener_incognito2("done_incognito", true);
 
   ReloadExtension(extension->id());
 
   EXPECT_TRUE(listener2.WaitUntilSatisfied());
   EXPECT_TRUE(listener_incognito2.WaitUntilSatisfied());
 }
+
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, ExtensionRequests) {
+  ASSERT_TRUE(StartEmbeddedTestServer());
+  ExtensionTestMessageListener listener_main("webRequestListening", true);
+  ExtensionTestMessageListener listener_app("app_done", false);
+  ExtensionTestMessageListener listener_extension("extension_done", false);

[not at google - send to devlin, 2015/08/04 20:27:02]

could you standardise on camelcase vs underscores?

[robwu, 2015/08/04 21:57:24]

Done.

+
+  // Set up webRequest listener
+  ASSERT_TRUE(LoadExtension(
+          test_data_dir_.AppendASCII("webrequest_extensions/main")));
+  EXPECT_TRUE(listener_main.WaitUntilSatisfied());
+
+  // Perform some network activity in an app and another extension.

[not at google - send to devlin, 2015/08/04 20:27:02]

1. The app and extension do slightly different things. They both fire XHR but
the extension is the one which triggers the navigation which ultimately
completes the test. This way of finishing the test seems arbitrary to me
actually; it's interesting to use the webRequest API to trigger it, but it would
be simpler to use extension messaging to communicate.

2. As I mentioned, it would be good to also have a test for a website that hosts
an extension's (web accessible of course) iframe, since that should bypass the
process ID check.

3. It would be good to test what functionality is supposed to work; intercepting
requests from yourself. It should be pretty straightforward to modify the "main"
extension to do an XHR before continuing with its test assertion.

[robwu, 2015/08/04 21:57:24]

Good point, done.
Done (with a content script).
This is already covered by other tests (e.g. BackgroundXhrTest.TlsClientAuth and
BackgroundXhrTest.HttpAuth).

+  ASSERT_TRUE(LoadExtension(
+          test_data_dir_.AppendASCII("webrequest_extensions/app")));
+  ASSERT_TRUE(LoadExtension(
+          test_data_dir_.AppendASCII("webrequest_extensions/extension")));
+
+  EXPECT_TRUE(listener_app.WaitUntilSatisfied());
+  EXPECT_TRUE(listener_extension.WaitUntilSatisfied());
+
+  // Collect result.
+  ExtensionTestMessageListener listener_done(false);
+  listener_main.Reply("");
+  EXPECT_TRUE(listener_done.WaitUntilSatisfied());
+
+  EXPECT_EQ("OK", listener_done.message());
+}